Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Miruro): add Presence #8744

Merged
merged 12 commits into from
Sep 27, 2024
Merged

feat(Miruro): add Presence #8744

merged 12 commits into from
Sep 27, 2024
+143 −0

Conversation

Neo1912
Copy link
Contributor

@Neo1912 Neo1912 commented Sep 20, 2024 •
edited
Loading

Description

add presence for Miruro

Acknowledgements

Screenshots

Proof showing the creation/modification is working as expected

image
image
image

darkvillager2
darkvillager2 suggested changes Sep 20, 2024
View reviewed changes
Copy link
Contributor

@darkvillager2 darkvillager2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, thanks for contributing!

If you have any questions about the requested changes feel free to dm me (Discord ois @Dark_Ville) or to ask in here!

websites/M/Miruro/presence.ts Outdated Show resolved Hide resolved
websites/M/Miruro/presence.ts Outdated Show resolved Hide resolved
websites/M/Miruro/presence.ts Outdated Show resolved Hide resolved
websites/M/Miruro/presence.ts Outdated Show resolved Hide resolved
websites/M/Miruro/presence.ts Outdated Show resolved Hide resolved
websites/M/Miruro/presence.ts Outdated Show resolved Hide resolved
websites/M/Miruro/presence.ts Outdated Show resolved Hide resolved
@darkvillager2
Copy link
Contributor

Also i don't seen any timestamps getting used is there a reason for that?

darkvillager2
darkvillager2 suggested changes Sep 21, 2024
View reviewed changes
websites/M/Miruro/metadata.json Outdated Show resolved Hide resolved
Bas950
Bas950 requested changes Sep 21, 2024
View reviewed changes
Copy link
Member

@Bas950 Bas950 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For the rest LGTM

websites/M/Miruro/presence.ts Outdated Show resolved Hide resolved
@Neo1912 Neo1912 requested a review from Bas950 September 21, 2024 19:17
theusaf
theusaf requested changes Sep 21, 2024
View reviewed changes
websites/M/Miruro/presence.ts Outdated Show resolved Hide resolved
@kaisei-kto kaisei-kto mentioned this pull request Sep 22, 2024
Closed
3 tasks
theusaf
theusaf requested changes Sep 26, 2024
View reviewed changes
Copy link
Member

@theusaf theusaf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this, LGTM

websites/M/Miruro/presence.ts Outdated Show resolved Hide resolved
@theusaf theusaf enabled auto-merge (squash) September 27, 2024 01:55
@theusaf theusaf merged commit a866eb5 into PreMiD:main Sep 27, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@darkvillager2 darkvillager2 darkvillager2 requested changes

@theusaf theusaf theusaf approved these changes

@Bas950 Bas950 Bas950 approved these changes

Assignees
No one assigned
Labels
new presence
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Neo1912 @darkvillager2 @theusaf @Bas950