Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add shuffling #283

Merged
merged 4 commits into from
Dec 14, 2023
Merged

Add shuffling #283

merged 4 commits into from
Dec 14, 2023

Conversation

hernanmd
Copy link
Collaborator

Add support for shuffling a DataFrame.

Hernán Morales Durand added 2 commits December 11, 2023 11:13
Add shuffleBy:
56d9923 
Add test
Add drop column method and test.
4878ce3 
Add test for shuffling a data frame
@hernanmd hernanmd self-assigned this Dec 14, 2023
@jecisc
Copy link
Member

jecisc commented Dec 14, 2023 

  ✗ #testShuffledWithSeed (71ms)
TestFailure: Got a DataFrame (3@3) instead of a DataFrame (3@3).
DataFrameTest(TestAsserter)>>assert:description:resumable:
DataFrameTest(TestAsserter)>>assert:description:
DataFrameTest(TestAsserter)>>assert:equals:
DataFrameTest>>testShuffledWithSeed ...assert: (df shuffleWithSeed: 1) equals: expected
SCICoverageWrapper>>run:with:in:
DataFrameTest(Object)>>perform:
DataFrameTest(TestCase)>>performTest

@hernanmd
Copy link
Collaborator Author

Adapted to handle different RNG implementation between previous versions and Pharo 12 and above

@jecisc jecisc merged commit a37feeb into master Dec 14, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jecisc jecisc jecisc approved these changes

Assignees

@hernanmd hernanmd

Labels
new feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hernanmd @jecisc