Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROPOSAL: Change logic on chain-evolution endpoint #909

Open
wants to merge 2 commits into
base: staging
Choose a base branch
from

Conversation

DylasX
Copy link
Contributor

@DylasX DylasX commented Jul 28, 2023

Hey,

Working with the endpoint evolution-chain, it's using the evolution_chain_id to filter and get the chain evolution so if you only have the pokemon_id and try to get the evolutions with that endpoint will generate a not expected response so that's why I did this proposal of change the chain id to pokemon id.

Thanks a lot!

@DylasX DylasX marked this pull request as ready for review July 28, 2023 02:09
@DylasX DylasX changed the title feat: change logic on chain-evolution endpoint PROPOSAL: Change logic on chain-evolution endpoint Jul 28, 2023
@Naramsim Naramsim added the v3 Changes to integrate in a possible new API version label Jul 28, 2023
@Naramsim Naramsim changed the base branch from master to staging July 28, 2023 08:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 Changes to integrate in a possible new API version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants