Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

dictionary from encounters subresource (#332) #335

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

jrubinator
Copy link

This makes it consistent with the every other resource
Unfortunately this isn't tested or testable in the current framework,
as distinct() is not supported by the sqlite3 backend

jrubinator and others added 2 commits April 20, 2018 23:40
This makes it consistent with the every other resource
Unfortunately this isn't tested or testable in the current framework,
as distinct() is not supported by the sqlite3 backend
@Naramsim Naramsim added the v3 Changes to integrate in a possible new API version label Jan 29, 2021
@omniuni
Copy link

omniuni commented Jun 2, 2024

The encounters resource, as it is, is really weird. I'd love to see this PR merged! One note about this; because it also changes the endpoint, this should be able to be updated so that it simply adds a new endpoint that operates as expected but leaves the old endpoint in the old format for compatibility.

@jrubinator
Copy link
Author

That's probably wise.

Commenting to say it's been a (very) long time since I worked on this, and I'm not interested in pushing for its merge at this point, but I would be thrilled if someone else got it to the finish line!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
v3 Changes to integrate in a possible new API version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants