Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

More OpenAPI examples #7

Draft
wants to merge 5 commits into
base: main
Choose a base branch
from
Draft

More OpenAPI examples #7

wants to merge 5 commits into from

Conversation

mojanas
Copy link
Collaborator

@mojanas mojanas commented Aug 10, 2023

Motivation and Context

Description

Contribution Checklist

await SkillImportExample();

// Example semantic skill for generating PlayFab segments
string[] questions = new string[]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

string[]

var

"How do I create a segment for players with high risk of churn who have spent over $100?"
};

foreach (string q in questions)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

question

"Do I have a segment that filters for Canadian players?",
};

foreach (string q in questions)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

q

question

@@ -26,7 +26,7 @@ public class SystemStep
/// Gets or sets the variables for the action
/// </summary>
[JsonPropertyName("action_variables")]
public Dictionary<string, string>? ActionVariables { get; set; }
public Dictionary<string, object>? ActionVariables { get; set; }
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

public Dictionary<string, object>? ActionVariables { get; set; }

why do we need to change that from string to object? I'm worried to diverge too much from the SK repo since at some point I'd like to move our solution to use the nuget package of SK

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe I changed this after running into some serialization issues with the playfab api body. I'll see if I can get it working without these changes

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can also create our own planner

{
"How do I create a segment for Android players in Canada?",
"How do I create a segment for players with high risk of churn who have spent over $100?"
};
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we make the two distinct list of questions into one?
(and then have something like the action-planner picking one of your skills to do the job)

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants