This repository has been archived by the owner on Aug 21, 2023. It is now read-only.
Basic version of create segment using azure open ai and semantic kernel sdk #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mojanas
reviewed
Aug 10, 2023
| @@ -25,58 +25,58 @@ public static async Task Main() | |||
| await Example_00_03_OpenApiSkill_PlayFab.RunAsync().SafeWaitAsync(cancelToken); | |||
|
|
|||
| // Run examples | |||
| await Example01_NativeFunctions.RunAsync().SafeWaitAsync(cancelToken); | |||
There was a problem hiding this comment.
Can ignore changes to this file for the PR
There was a problem hiding this comment.
Sure, I will revert. But all the examples will run whenever we run the project, so these are not required and save time if we comment.
| .WithAzureTextCompletionService("text-davinci-003", TestConfiguration.AzureOpenAI.Endpoint, TestConfiguration.AzureOpenAI.ApiKey) // Note: Action Planner works with old models like text-davinci-002 | ||
| .Build(); | ||
|
|
||
| string folder = RepoFiles.SampleSkillsPath(); |
| Console.WriteLine("======== Action Planner ========"); | ||
| var kernel2 = new KernelBuilder() | ||
| .WithLogger(ConsoleLogger.Logger) | ||
| .WithAzureTextCompletionService("text-davinci-003", TestConfiguration.AzureOpenAI.Endpoint, TestConfiguration.AzureOpenAI.ApiKey) // Note: Action Planner works with old models like text-davinci-002 |
| // Create a segment skill | ||
| { | ||
| Console.WriteLine("======== Action Planner ========"); | ||
| var kernel2 = new KernelBuilder() |
| private static async Task CreateSegmentExample(string goal) | ||
| { | ||
| // Create a segment skill | ||
| { |
There was a problem hiding this comment.
{ [](http://example.com/codeflow?start=1&length=8)
remove brackets #Resolved
| "Create a segment with name WelcomeEgyptNewPlayers for the players located in the Egypt with entered segment action of email notification?", // With entered segment action | ||
| "Create a segment with name EgyptNewPlayers for the players located in the Egypt?" // If the segment already exist, create a segment with name appended with guid | ||
| }; | ||
| await CreateSegmentExample(goals[0]); |
There was a problem hiding this comment.
Since these are create operations, same segment name won't work every time for now. Later I will add logic to rename if the segment already exist.
| /// </summary> | ||
| public sealed class SegmentSkill | ||
| { | ||
| ContextVariables contextVariables = new ContextVariables(); |
| { | ||
| //ToDo: Create payload json using Playfab dlls/sdk | ||
| // Set properties to create a Segment using swagger.json | ||
| ContextVariables contextVariables = new ContextVariables(); |
| countryCodes.Add("Australia", "AU"); | ||
| countryCodes.Add("Kenya", "KE"); | ||
| countryCodes.Add("Egypt", "EG"); | ||
| countryCodes.Add("China", "CN"); |
There was a problem hiding this comment.
I feel like this shouldn't be needed. With an appropriate description, the model should return an appropriate country codes. Country codes are well known and the model should just have the right documentation to tell it to do so
There was a problem hiding this comment.
Wav.. It worked just by updating the description :)
| string segmentPayload = "{\n \"SegmentModel\": {\n \"Name\": \"<SegmentName>\",\n \"SegmentOrDefinitions\": [\n {\n \"SegmentAndDefinitions\": [\n {\n \"<SegmentDefinition>\": {\n \"LogInDate\": \"<SegmentComparisonValue>T00:00:00Z\",\n \"Comparison\": \"<SegmentComparison>\"\n }\n }\n ]\n }\n ]\n }\n }"; | ||
| string locationPayload = "{\n \"SegmentModel\": {\n \"Name\": \"<SegmentName>\",\n \"SegmentOrDefinitions\": [\n {\n \"SegmentAndDefinitions\": [\n {\n \"<SegmentDefinition>\": {\n \"CountryCode\": \"<SegmentComparisonValue>\",\n \"Comparison\": \"<SegmentComparison>\"\n }\n }\n ]\n }\n ]\n }\n }"; | ||
|
|
||
| if (segmentdefinition == "LocationFilter") |
There was a problem hiding this comment.
Wav.. It worked just by updating description :)
| ContextVariables contextVariables = new(); | ||
| contextVariables.Set("content_type", "application/json"); | ||
| contextVariables.Set("server_url", TestConfiguration.PlayFab.Endpoint); | ||
| string segmentPayload = GetSegmentPayload(segmentname, segmentdefinition, segmentcomparison, segmentcomparisonvalue, segmentaction, segmentactioncode, segmentactionvalue); |
There was a problem hiding this comment.
yes, I will look into it after this pr. Just want to keep some working code.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation and Context
This pr contains 3 basic examples of create segments.
Its having create segment skill and make it work with example file.
Description
Contribution Checklist