Skip to content
This repository has been archived by the owner on Aug 21, 2023. It is now read-only.

Sync upstream #14

Merged
merged 2 commits into from
Aug 15, 2023
Merged

Sync upstream #14

merged 2 commits into from
Aug 15, 2023

Commits on Aug 15, 2023

  1. .Net: [Error handling] [Part4] Replacing KernelException and OpenAIIn…

    …validResponseException exceptions by SKException (microsoft#2362)
    
    ### Motivation and Context
    This PR is one of the follow-up PRs aimed at gradually replacing SK
    custom exceptions with SKException to provide a simple, consistent, and
    extensible exception model. You can find more details in the
    [ADR](https://github.com/microsoft/semantic-kernel/blob/main/docs/decisions/0004-error-handling.md)
    discussing error handling.
    
    ### Description
    This PR updates a few SK components to throw SKException instead of
    KernelException and OpenAIInvalidResponseException, and removes those
    exceptions.
    
    ### Contribution Checklist
    
    <!-- Before submitting this PR, please make sure: -->
    
    - [x] The code builds clean without any errors or warnings
    - [x] The PR follows the [SK Contribution
    Guidelines](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md)
    and the [pre-submission formatting
    script](https://github.com/microsoft/semantic-kernel/blob/main/CONTRIBUTING.md#development-scripts)
    raises no violations
    - [x] All unit tests pass, and I have added new tests where possible
    - [x] I didn't break anyone 😄
    
    ---------
    
    Co-authored-by: Roger Barreto <[email protected]>
    Co-authored-by: Dmytro Struk <[email protected]>
    Co-authored-by: Shawn Callegari <[email protected]>
    4 people authored Aug 15, 2023
    Configuration menu
    Copy the full SHA
    147b43f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    9abb13d View commit details
    Browse the repository at this point in the history