Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Have to_sfl use NFP in the grids used to fit new Equilibrium #1246

Merged
merged 1 commit into from
Sep 10, 2024

Conversation

dpanici
Copy link
Collaborator

@dpanici dpanici commented Sep 7, 2024

No description provided.

@dpanici dpanici added the easy Short and simple to code or review label Sep 7, 2024
Copy link
Contributor

github-actions bot commented Sep 7, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     +0.67 +/- 3.89     | +3.43e-03 +/- 1.99e-02 |  5.15e-01 +/- 1.9e-02  |  5.11e-01 +/- 4.8e-03  |
 test_equilibrium_init_medres            |     +0.60 +/- 0.28     | +2.42e-02 +/- 1.14e-02 |  4.06e+00 +/- 6.2e-03  |  4.03e+00 +/- 9.5e-03  |
 test_equilibrium_init_highres           |     +0.69 +/- 0.55     | +3.72e-02 +/- 2.96e-02 |  5.41e+00 +/- 2.1e-02  |  5.37e+00 +/- 2.1e-02  |
 test_objective_compile_dshape_current   |     +0.17 +/- 0.70     | +6.34e-03 +/- 2.65e-02 |  3.81e+00 +/- 2.1e-02  |  3.80e+00 +/- 1.6e-02  |
 test_objective_compute_dshape_current   |     +0.27 +/- 1.54     | +9.41e-06 +/- 5.29e-05 |  3.45e-03 +/- 4.6e-05  |  3.44e-03 +/- 2.6e-05  |
 test_objective_jac_dshape_current       |     -0.58 +/- 7.37     | -2.34e-04 +/- 2.97e-03 |  4.00e-02 +/- 1.6e-03  |  4.02e-02 +/- 2.5e-03  |
 test_perturb_2                          |     +0.69 +/- 1.45     | +1.17e-01 +/- 2.46e-01 |  1.71e+01 +/- 1.6e-01  |  1.70e+01 +/- 1.8e-01  |
 test_proximal_freeb_jac                 |     -1.44 +/- 1.03     | -1.07e-01 +/- 7.66e-02 |  7.33e+00 +/- 6.5e-02  |  7.44e+00 +/- 4.0e-02  |
 test_solve_fixed_iter                   |     -0.89 +/- 60.21    | -4.48e-02 +/- 3.02e+00 |  4.97e+00 +/- 2.1e+00  |  5.01e+00 +/- 2.1e+00  |

Copy link

codecov bot commented Sep 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.44%. Comparing base (6ab8327) to head (34d3808).
Report is 2 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1246   +/-   ##
=======================================
  Coverage   95.44%   95.44%           
=======================================
  Files          95       95           
  Lines       23402    23402           
=======================================
  Hits        22337    22337           
  Misses       1065     1065           
Files with missing lines Coverage Δ
desc/equilibrium/coords.py 88.75% <100.00%> (ø)

... and 2 files with indirect coverage changes

@dpanici dpanici requested review from a team, rahulgaur104, f0uriest, ddudt, kianorr, sinaatalay, unalmis and YigitElma and removed request for a team September 8, 2024 09:38
@dpanici dpanici merged commit 12441ac into master Sep 10, 2024
26 checks passed
@dpanici dpanici deleted the dp/sfl-NFP branch September 10, 2024 00:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy Short and simple to code or review
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants