Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bug fix for CoilCurrentLength #1146

Merged
merged 2 commits into from
Jul 24, 2024
Merged

bug fix for CoilCurrentLength #1146

merged 2 commits into from
Jul 24, 2024

Conversation

ddudt
Copy link
Collaborator

@ddudt ddudt commented Jul 24, 2024

The output of CoilCurrentLength is a 2D array of shape (dim_f, dim_f), this corrects it to be a 1D array of shape (dim_f,).

@ddudt ddudt added coil stuff relating to coils and coil optimization easy Short and simple to code or review EZ-review bug fix Something was fixed labels Jul 24, 2024
@dpanici dpanici added the urgent Something we should fix/improve soon label Jul 24, 2024
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.24%. Comparing base (b15a24f) to head (777d4ea).

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1146      +/-   ##
==========================================
- Coverage   95.24%   95.24%   -0.01%     
==========================================
  Files          87       87              
  Lines       21947    21947              
==========================================
- Hits        20904    20903       -1     
- Misses       1043     1044       +1     
Files Coverage Δ
desc/objectives/_coils.py 99.14% <100.00%> (ø)

... and 1 file with indirect coverage changes

Copy link
Contributor

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     +0.07 +/- 8.32     | +3.81e-04 +/- 4.46e-02 |  5.36e-01 +/- 3.7e-02  |  5.36e-01 +/- 2.5e-02  |
 test_build_transform_fft_midres         |     -3.29 +/- 5.59     | -2.05e-02 +/- 3.48e-02 |  6.03e-01 +/- 2.7e-02  |  6.23e-01 +/- 2.2e-02  |
 test_build_transform_fft_highres        |     -4.33 +/- 5.71     | -4.52e-02 +/- 5.96e-02 |  9.99e-01 +/- 3.0e-02  |  1.04e+00 +/- 5.2e-02  |
 test_equilibrium_init_lowres            |     +3.22 +/- 6.97     | +1.22e-01 +/- 2.63e-01 |  3.89e+00 +/- 2.1e-01  |  3.77e+00 +/- 1.6e-01  |
 test_equilibrium_init_medres            |     +4.04 +/- 6.07     | +1.71e-01 +/- 2.57e-01 |  4.40e+00 +/- 2.4e-01  |  4.23e+00 +/- 9.0e-02  |
 test_equilibrium_init_highres           |     -0.41 +/- 3.70     | -2.35e-02 +/- 2.11e-01 |  5.66e+00 +/- 1.6e-01  |  5.68e+00 +/- 1.4e-01  |
 test_objective_compile_dshape_current   |     -1.91 +/- 1.69     | -7.57e-02 +/- 6.70e-02 |  3.88e+00 +/- 4.8e-02  |  3.95e+00 +/- 4.7e-02  |
 test_objective_compile_atf              |     +0.11 +/- 2.50     | +9.62e-03 +/- 2.12e-01 |  8.48e+00 +/- 2.0e-01  |  8.47e+00 +/- 7.0e-02  |
 test_objective_compute_dshape_current   |     -0.99 +/- 5.28     | -1.25e-05 +/- 6.66e-05 |  1.25e-03 +/- 3.4e-05  |  1.26e-03 +/- 5.8e-05  |
 test_objective_compute_atf              |    -14.52 +/- 6.26     | -7.18e-04 +/- 3.09e-04 |  4.23e-03 +/- 1.5e-04  |  4.94e-03 +/- 2.7e-04  |
 test_objective_jac_dshape_current       |     -5.02 +/- 10.95    | -1.99e-03 +/- 4.33e-03 |  3.76e-02 +/- 1.8e-03  |  3.96e-02 +/- 3.9e-03  |
 test_objective_jac_atf                  |     -1.97 +/- 4.71     | -3.75e-02 +/- 8.98e-02 |  1.87e+00 +/- 4.6e-02  |  1.91e+00 +/- 7.7e-02  |
 test_perturb_1                          |     +0.78 +/- 2.85     | +1.08e-01 +/- 3.97e-01 |  1.41e+01 +/- 1.6e-01  |  1.40e+01 +/- 3.6e-01  |
 test_perturb_2                          |     +0.90 +/- 5.52     | +1.72e-01 +/- 1.05e+00 |  1.92e+01 +/- 5.0e-01  |  1.90e+01 +/- 9.2e-01  |
 test_proximal_jac_atf                   |     +1.40 +/- 1.42     | +1.02e-01 +/- 1.04e-01 |  7.42e+00 +/- 8.1e-02  |  7.32e+00 +/- 6.4e-02  |
 test_proximal_freeb_compute             |     -0.86 +/- 1.14     | -1.53e-03 +/- 2.04e-03 |  1.78e-01 +/- 1.7e-03  |  1.79e-01 +/- 1.2e-03  |
 test_proximal_freeb_jac                 |     +0.38 +/- 2.13     | +2.85e-02 +/- 1.60e-01 |  7.57e+00 +/- 1.0e-01  |  7.54e+00 +/- 1.2e-01  |
 test_solve_fixed_iter                   |     +0.21 +/- 6.82     | +3.79e-02 +/- 1.25e+00 |  1.83e+01 +/- 8.7e-01  |  1.83e+01 +/- 8.9e-01  |

@ddudt ddudt merged commit 8d71ffd into master Jul 24, 2024
20 checks passed
@ddudt ddudt deleted the dd/current-length branch July 24, 2024 23:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Something was fixed coil stuff relating to coils and coil optimization easy Short and simple to code or review urgent Something we should fix/improve soon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants