Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change description of ds to be clear what it actually is #1140

Merged
merged 8 commits into from
Aug 15, 2024
Merged

Conversation

dpanici
Copy link
Collaborator

@dpanici dpanici commented Jul 23, 2024

Resolves #1093

@unalmis unalmis changed the title Remove ds from compute index in favor of using grad spacing directly Remove ds from compute index in favor of using grid spacing directly Jul 23, 2024
Copy link
Contributor

github-actions bot commented Jul 23, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     -2.12 +/- 10.01    | -1.13e-02 +/- 5.34e-02 |  5.23e-01 +/- 3.0e-02  |  5.34e-01 +/- 4.4e-02  |
 test_build_transform_fft_midres         |     +1.50 +/- 4.47     | +8.91e-03 +/- 2.66e-02 |  6.04e-01 +/- 2.4e-02  |  5.95e-01 +/- 1.1e-02  |
 test_build_transform_fft_highres        |     -2.10 +/- 3.80     | -2.12e-02 +/- 3.84e-02 |  9.90e-01 +/- 3.4e-02  |  1.01e+00 +/- 1.8e-02  |
 test_equilibrium_init_lowres            |     -1.08 +/- 5.00     | -4.02e-02 +/- 1.87e-01 |  3.70e+00 +/- 1.1e-01  |  3.74e+00 +/- 1.5e-01  |
 test_equilibrium_init_medres            |     +1.41 +/- 4.09     | +5.83e-02 +/- 1.69e-01 |  4.19e+00 +/- 1.2e-01  |  4.14e+00 +/- 1.2e-01  |
 test_equilibrium_init_highres           |     -4.55 +/- 4.23     | -2.68e-01 +/- 2.49e-01 |  5.63e+00 +/- 2.2e-01  |  5.89e+00 +/- 1.2e-01  |
 test_objective_compile_dshape_current   |     -3.11 +/- 2.28     | -1.26e-01 +/- 9.22e-02 |  3.92e+00 +/- 7.2e-02  |  4.04e+00 +/- 5.8e-02  |
 test_objective_compile_atf              |     -0.56 +/- 2.59     | -4.73e-02 +/- 2.18e-01 |  8.39e+00 +/- 1.5e-01  |  8.44e+00 +/- 1.6e-01  |
 test_objective_compute_dshape_current   |     -0.16 +/- 36.15    | -2.10e-06 +/- 4.70e-04 |  1.30e-03 +/- 4.6e-04  |  1.30e-03 +/- 7.0e-05  |
 test_objective_compute_atf              |     -5.65 +/- 4.16     | -2.52e-04 +/- 1.85e-04 |  4.21e-03 +/- 1.5e-04  |  4.46e-03 +/- 1.1e-04  |
 test_objective_jac_dshape_current       |     -4.78 +/- 6.96     | -1.90e-03 +/- 2.76e-03 |  3.77e-02 +/- 1.9e-03  |  3.96e-02 +/- 2.0e-03  |
 test_objective_jac_atf                  |     +0.20 +/- 3.05     | +3.71e-03 +/- 5.67e-02 |  1.86e+00 +/- 2.5e-02  |  1.86e+00 +/- 5.1e-02  |
 test_perturb_1                          |     +3.09 +/- 2.76     | +4.22e-01 +/- 3.76e-01 |  1.41e+01 +/- 2.6e-01  |  1.36e+01 +/- 2.7e-01  |
 test_perturb_2                          |     +1.14 +/- 2.65     | +2.16e-01 +/- 5.00e-01 |  1.91e+01 +/- 2.3e-01  |  1.89e+01 +/- 4.4e-01  |
 test_proximal_jac_atf                   |     +0.21 +/- 2.05     | +1.54e-02 +/- 1.50e-01 |  7.30e+00 +/- 1.1e-01  |  7.28e+00 +/- 1.0e-01  |
 test_proximal_freeb_compute             |     -0.04 +/- 1.06     | -6.34e-05 +/- 1.91e-03 |  1.79e-01 +/- 1.6e-03  |  1.79e-01 +/- 9.8e-04  |
 test_proximal_freeb_jac                 |     +0.77 +/- 1.13     | +5.69e-02 +/- 8.29e-02 |  7.41e+00 +/- 7.0e-02  |  7.35e+00 +/- 4.4e-02  |
 test_solve_fixed_iter                   |     +1.42 +/- 8.81     | +2.57e-01 +/- 1.60e+00 |  1.84e+01 +/- 1.5e+00  |  1.81e+01 +/- 5.6e-01  |

@dpanici dpanici marked this pull request as draft July 23, 2024 23:51
@dpanici
Copy link
Collaborator Author

dpanici commented Jul 24, 2024

just change description of ds

Copy link

codecov bot commented Aug 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 95.45%. Comparing base (2d3c303) to head (37d8296).
Report is 9 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1140      +/-   ##
==========================================
+ Coverage   88.62%   95.45%   +6.83%     
==========================================
  Files          87       87              
  Lines       22265    22265              
==========================================
+ Hits        19732    21253    +1521     
+ Misses       2533     1012    -1521     
Files Coverage Δ
desc/compute/_curve.py 100.00% <ø> (+0.59%) ⬆️

... and 41 files with indirect coverage changes

@dpanici dpanici marked this pull request as ready for review August 14, 2024 15:06
@dpanici dpanici changed the title Remove ds from compute index in favor of using grid spacing directly Change description of ds to be clear what it actually is Aug 14, 2024
desc/compute/_curve.py Outdated Show resolved Hide resolved
@dpanici dpanici merged commit f27e5fa into master Aug 15, 2024
18 checks passed
@dpanici dpanici deleted the dp/remove-ds branch August 15, 2024 02:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ds compute quantity for Curve is not correct when NFP is not equal to 1
3 participants