Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jitable to surface compute to fix JAX error #1092

Closed
wants to merge 2 commits into from

Conversation

dpanici
Copy link
Collaborator

@dpanici dpanici commented Jul 2, 2024

  • Adds jitable as a kwarg to get_transforms in Surface.compute to avoid errors when jitting the .compute_magnetic_field method of surface current objects

@dpanici
Copy link
Collaborator Author

dpanici commented Jul 2, 2024

Putting change in #1002 instead

@dpanici dpanici closed this Jul 2, 2024
Copy link
Contributor

github-actions bot commented Jul 2, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     +0.57 +/- 3.46     | +2.95e-03 +/- 1.79e-02 |  5.21e-01 +/- 1.6e-02  |  5.18e-01 +/- 8.8e-03  |
 test_build_transform_fft_midres         |     +1.12 +/- 5.09     | +6.68e-03 +/- 3.04e-02 |  6.05e-01 +/- 3.0e-02  |  5.98e-01 +/- 6.7e-03  |
 test_build_transform_fft_highres        |     +0.13 +/- 1.60     | +1.26e-03 +/- 1.60e-02 |  9.99e-01 +/- 8.8e-03  |  9.98e-01 +/- 1.3e-02  |
 test_equilibrium_init_lowres            |     -0.38 +/- 0.79     | -1.44e-02 +/- 2.96e-02 |  3.75e+00 +/- 1.4e-02  |  3.77e+00 +/- 2.6e-02  |
 test_equilibrium_init_medres            |     +0.26 +/- 1.04     | +1.12e-02 +/- 4.40e-02 |  4.25e+00 +/- 3.5e-02  |  4.24e+00 +/- 2.7e-02  |
 test_equilibrium_init_highres           |     +0.08 +/- 0.82     | +4.36e-03 +/- 4.66e-02 |  5.65e+00 +/- 2.7e-02  |  5.65e+00 +/- 3.8e-02  |
 test_objective_compile_dshape_current   |     -0.13 +/- 1.13     | -5.00e-03 +/- 4.36e-02 |  3.84e+00 +/- 1.7e-02  |  3.85e+00 +/- 4.0e-02  |
 test_objective_compile_atf              |     -0.46 +/- 3.56     | -3.84e-02 +/- 2.97e-01 |  8.32e+00 +/- 2.4e-01  |  8.36e+00 +/- 1.7e-01  |
 test_objective_compute_dshape_current   |     -1.63 +/- 3.96     | -2.10e-05 +/- 5.11e-05 |  1.27e-03 +/- 3.6e-05  |  1.29e-03 +/- 3.6e-05  |
 test_objective_compute_atf              |     -3.16 +/- 4.52     | -1.41e-04 +/- 2.01e-04 |  4.31e-03 +/- 1.6e-04  |  4.46e-03 +/- 1.3e-04  |
 test_objective_jac_dshape_current       |     +0.97 +/- 15.94    | +3.69e-04 +/- 6.09e-03 |  3.86e-02 +/- 5.8e-03  |  3.82e-02 +/- 1.9e-03  |
 test_objective_jac_atf                  |     +3.66 +/- 1.87     | +7.07e-02 +/- 3.60e-02 |  2.00e+00 +/- 1.5e-02  |  1.93e+00 +/- 3.3e-02  |
 test_perturb_1                          |     -0.09 +/- 1.82     | -1.24e-02 +/- 2.43e-01 |  1.33e+01 +/- 1.3e-01  |  1.33e+01 +/- 2.1e-01  |
 test_perturb_2                          |     +0.26 +/- 1.18     | +4.82e-02 +/- 2.16e-01 |  1.84e+01 +/- 1.6e-01  |  1.83e+01 +/- 1.5e-01  |
 test_proximal_jac_atf                   |     +0.41 +/- 1.64     | +3.05e-02 +/- 1.22e-01 |  7.44e+00 +/- 7.7e-02  |  7.41e+00 +/- 9.4e-02  |
 test_proximal_freeb_compute             |     -1.44 +/- 0.86     | -2.57e-03 +/- 1.54e-03 |  1.76e-01 +/- 7.3e-04  |  1.79e-01 +/- 1.4e-03  |
 test_proximal_freeb_jac                 |     -0.75 +/- 1.24     | -5.58e-02 +/- 9.24e-02 |  7.37e+00 +/- 5.8e-02  |  7.43e+00 +/- 7.2e-02  |
 test_solve_fixed_iter                   |     -0.44 +/- 9.53     | -6.63e-02 +/- 1.43e+00 |  1.49e+01 +/- 9.8e-01  |  1.50e+01 +/- 1.0e+00  |

@unalmis unalmis deleted the dp/fix-surface-field-jax-error branch July 11, 2024 23:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant