Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make VMEC load docstring more clear about what it is doing #1091

Merged
merged 1 commit into from
Jul 2, 2024

Conversation

dpanici
Copy link
Collaborator

@dpanici dpanici commented Jul 2, 2024

No description provided.

Copy link

codecov bot commented Jul 2, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.98%. Comparing base (5d3af14) to head (8e51ddc).

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1091   +/-   ##
=======================================
  Coverage   94.98%   94.98%           
=======================================
  Files          87       87           
  Lines       21743    21743           
=======================================
  Hits        20652    20652           
  Misses       1091     1091           
Files Coverage Δ
desc/vmec.py 92.21% <ø> (ø)

Copy link
Contributor

github-actions bot commented Jul 2, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     -1.76 +/- 5.17     | -9.85e-03 +/- 2.89e-02 |  5.48e-01 +/- 2.2e-02  |  5.58e-01 +/- 1.9e-02  |
 test_build_transform_fft_midres         |     -1.54 +/- 2.75     | -9.91e-03 +/- 1.77e-02 |  6.34e-01 +/- 1.1e-02  |  6.44e-01 +/- 1.4e-02  |
 test_build_transform_fft_highres        |     +0.25 +/- 3.03     | +2.60e-03 +/- 3.11e-02 |  1.03e+00 +/- 2.1e-02  |  1.03e+00 +/- 2.3e-02  |
 test_equilibrium_init_lowres            |     +0.74 +/- 2.50     | +2.98e-02 +/- 1.01e-01 |  4.07e+00 +/- 8.4e-02  |  4.04e+00 +/- 5.7e-02  |
 test_equilibrium_init_medres            |     -0.68 +/- 2.46     | -3.13e-02 +/- 1.13e-01 |  4.58e+00 +/- 8.5e-02  |  4.61e+00 +/- 7.5e-02  |
 test_equilibrium_init_highres           |     +0.51 +/- 1.91     | +3.02e-02 +/- 1.13e-01 |  5.97e+00 +/- 7.6e-02  |  5.94e+00 +/- 8.4e-02  |
 test_objective_compile_dshape_current   |     -0.02 +/- 1.97     | -9.50e-04 +/- 7.83e-02 |  3.98e+00 +/- 5.0e-02  |  3.98e+00 +/- 6.1e-02  |
 test_objective_compile_atf              |     -1.49 +/- 3.98     | -1.28e-01 +/- 3.41e-01 |  8.46e+00 +/- 2.7e-01  |  8.58e+00 +/- 2.1e-01  |
 test_objective_compute_dshape_current   |     -1.10 +/- 3.46     | -1.41e-05 +/- 4.45e-05 |  1.27e-03 +/- 2.9e-05  |  1.29e-03 +/- 3.4e-05  |
 test_objective_compute_atf              |     +3.85 +/- 7.18     | +1.72e-04 +/- 3.21e-04 |  4.64e-03 +/- 2.0e-04  |  4.46e-03 +/- 2.5e-04  |
 test_objective_jac_dshape_current       |     -0.40 +/- 7.11     | -1.54e-04 +/- 2.75e-03 |  3.85e-02 +/- 1.7e-03  |  3.86e-02 +/- 2.2e-03  |
 test_objective_jac_atf                  |     +1.28 +/- 2.07     | +2.43e-02 +/- 3.93e-02 |  1.92e+00 +/- 2.7e-02  |  1.90e+00 +/- 2.9e-02  |
 test_perturb_1                          |     +2.39 +/- 1.81     | +3.27e-01 +/- 2.48e-01 |  1.40e+01 +/- 5.0e-02  |  1.37e+01 +/- 2.4e-01  |
 test_perturb_2                          |     -0.19 +/- 1.78     | -3.65e-02 +/- 3.45e-01 |  1.93e+01 +/- 1.9e-01  |  1.94e+01 +/- 2.9e-01  |
 test_proximal_jac_atf                   |     +0.58 +/- 1.47     | +4.31e-02 +/- 1.10e-01 |  7.49e+00 +/- 6.2e-02  |  7.44e+00 +/- 9.0e-02  |
 test_proximal_freeb_compute             |     +0.40 +/- 0.94     | +7.05e-04 +/- 1.67e-03 |  1.79e-01 +/- 1.0e-03  |  1.78e-01 +/- 1.3e-03  |
 test_proximal_freeb_jac                 |     -1.40 +/- 1.81     | -1.06e-01 +/- 1.38e-01 |  7.50e+00 +/- 5.3e-02  |  7.60e+00 +/- 1.3e-01  |
 test_solve_fixed_iter                   |     +0.69 +/- 7.19     | +1.07e-01 +/- 1.11e+00 |  1.56e+01 +/- 8.1e-01  |  1.55e+01 +/- 7.6e-01  |

@dpanici dpanici merged commit 4745460 into master Jul 2, 2024
20 checks passed
@dpanici dpanici deleted the dp/vmec-doc branch July 2, 2024 23:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants