Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix map_coordinates errors for toroidal current equilibrium #1009

Merged
merged 4 commits into from
May 2, 2024

Conversation

unalmis
Copy link
Collaborator

@unalmis unalmis commented Apr 30, 2024

Resolves #1008

@unalmis unalmis requested a review from f0uriest April 30, 2024 01:28
Copy link

codecov bot commented Apr 30, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.94%. Comparing base (104e563) to head (dabfe0a).
Report is 1557 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #1009   +/-   ##
=======================================
  Coverage   94.93%   94.94%           
=======================================
  Files          87       87           
  Lines       21879    21880    +1     
=======================================
+ Hits        20771    20773    +2     
+ Misses       1108     1107    -1     
Files with missing lines Coverage Δ
desc/equilibrium/coords.py 96.96% <100.00%> (+0.52%) ⬆️

tests/test_equilibrium.py Outdated Show resolved Hide resolved
Copy link
Contributor

github-actions bot commented Apr 30, 2024

|             benchmark_name             |         dt(%)          |         dt(s)          |        t_new(s)        |        t_old(s)        | 
| -------------------------------------- | ---------------------- | ---------------------- | ---------------------- | ---------------------- |
 test_build_transform_fft_lowres         |     +0.01 +/- 5.03     | +2.76e-05 +/- 2.55e-02 |  5.06e-01 +/- 2.5e-02  |  5.06e-01 +/- 4.8e-03  |
 test_build_transform_fft_midres         |     -0.90 +/- 3.01     | -5.28e-03 +/- 1.76e-02 |  5.79e-01 +/- 1.6e-02  |  5.84e-01 +/- 7.3e-03  |
 test_build_transform_fft_highres        |     +0.31 +/- 1.88     | +3.09e-03 +/- 1.85e-02 |  9.92e-01 +/- 1.6e-02  |  9.88e-01 +/- 9.5e-03  |
 test_equilibrium_init_lowres            |     +3.56 +/- 6.22     | +1.41e-01 +/- 2.46e-01 |  4.10e+00 +/- 2.3e-01  |  3.96e+00 +/- 8.3e-02  |
 test_equilibrium_init_medres            |     +0.54 +/- 2.04     | +2.42e-02 +/- 9.07e-02 |  4.48e+00 +/- 4.8e-02  |  4.46e+00 +/- 7.7e-02  |
 test_equilibrium_init_highres           |     +1.08 +/- 4.77     | +6.77e-02 +/- 2.99e-01 |  6.32e+00 +/- 2.5e-01  |  6.25e+00 +/- 1.6e-01  |
 test_objective_compile_dshape_current   |     -0.14 +/- 2.33     | -5.28e-03 +/- 8.48e-02 |  3.63e+00 +/- 3.8e-02  |  3.64e+00 +/- 7.6e-02  |
 test_objective_compile_atf              |     -0.92 +/- 5.38     | -6.58e-02 +/- 3.86e-01 |  7.12e+00 +/- 2.1e-01  |  7.18e+00 +/- 3.2e-01  |
 test_objective_compute_dshape_current   |     -1.29 +/- 4.21     | -5.08e-05 +/- 1.66e-04 |  3.90e-03 +/- 1.3e-04  |  3.95e-03 +/- 1.1e-04  |
 test_objective_compute_atf              |     -3.73 +/- 2.39     | -6.75e-04 +/- 4.33e-04 |  1.74e-02 +/- 1.2e-04  |  1.81e-02 +/- 4.2e-04  |
 test_objective_jac_dshape_current       |     -1.19 +/- 11.50    | -5.10e-04 +/- 4.92e-03 |  4.22e-02 +/- 3.6e-03  |  4.27e-02 +/- 3.3e-03  |
 test_objective_jac_atf                  |     -0.19 +/- 2.74     | -3.60e-03 +/- 5.17e-02 |  1.88e+00 +/- 3.2e-02  |  1.89e+00 +/- 4.0e-02  |
 test_perturb_1                          |     +3.47 +/- 4.02     | +3.95e-01 +/- 4.57e-01 |  1.18e+01 +/- 1.8e-01  |  1.14e+01 +/- 4.2e-01  |
 test_perturb_2                          |     +5.37 +/- 2.76     | +8.67e-01 +/- 4.46e-01 |  1.70e+01 +/- 2.7e-01  |  1.62e+01 +/- 3.6e-01  |
 test_proximal_jac_atf                   |     +0.66 +/- 1.94     | +4.62e-02 +/- 1.35e-01 |  7.03e+00 +/- 1.1e-01  |  6.99e+00 +/- 7.8e-02  |
 test_proximal_freeb_compute             |     +1.62 +/- 0.89     | +2.07e-03 +/- 1.13e-03 |  1.30e-01 +/- 8.8e-04  |  1.28e-01 +/- 7.1e-04  |
 test_proximal_freeb_jac                 |     -0.95 +/- 3.53     | -6.78e-02 +/- 2.53e-01 |  7.10e+00 +/- 2.5e-01  |  7.16e+00 +/- 5.9e-02  |

@YigitElma YigitElma changed the title Resolves #1008 Fix map_coordinates errors for toroidal current equilibrium Apr 30, 2024
f0uriest
f0uriest previously approved these changes May 1, 2024
dpanici
dpanici previously approved these changes May 1, 2024
@unalmis unalmis dismissed stale reviews from dpanici and f0uriest via dabfe0a May 1, 2024 22:11
@unalmis unalmis requested review from ddudt, dpanici and f0uriest May 1, 2024 22:11
@unalmis unalmis merged commit b68c98c into master May 2, 2024
18 checks passed
@unalmis unalmis deleted the map_coords_missing_params branch May 2, 2024 04:08
@unalmis unalmis added the bug fix Something was fixed label Jul 22, 2024
@unalmis unalmis self-assigned this Aug 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fix Something was fixed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

map_coordinates errors for toroidal current equilibrium
5 participants