Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Candidate for 2.0.0 #89

Merged
merged 78 commits into from
Jun 5, 2024
Merged

Candidate for 2.0.0 #89

merged 78 commits into from
Jun 5, 2024

Conversation

GallVp
Copy link
Member

@GallVp GallVp commented May 30, 2024

PR checklist

  • Candidate for 2.0.0
  • If you've fixed a bug or added code that should be tested, add tests!
  • If you've added a new tool - have you followed the pipeline conventions in the contribution docs
  • Make sure your code lints (nf-core lint) and (pre-commit run --all)
  • Ensure the test suite passes (nextflow run . -profile test,docker --outdir <OUTDIR>).
  • Check for unexpected warnings in debug mode (nextflow run . -profile debug,test,docker --outdir <OUTDIR>).
  • Usage Documentation in docs/usage.md is updated.
  • Output Documentation in docs/output.md is updated.
  • CHANGELOG.md is updated.
  • README.md is updated (including new tool citations and authors/contributors).

Issues:

Copy link

github-actions bot commented May 30, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 5474d3a

+| ✅ 199 tests passed       |+
#| ❔  20 tests were ignored |#
!| ❗   1 tests had warnings |!

❗ Test warnings:

❔ Tests ignored:

  • files_exist - File is ignored: CODE_OF_CONDUCT.md
  • files_exist - File is ignored: assets/nf-core-assemblyqc_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-assemblyqc_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-assemblyqc_logo_dark.png
  • files_exist - File is ignored: .github/ISSUE_TEMPLATE/config.yml
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • files_exist - File is ignored: assets/multiqc_config.yml
  • files_exist - File is ignored: conf/igenomes.config
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: CODE_OF_CONDUCT.md
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File does not exist: .github/ISSUE_TEMPLATE/config.yml
  • files_unchanged - File ignored due to lint config: .github/workflows/linting.yml
  • files_unchanged - File ignored due to lint config: assets/nf-core-assemblyqc_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-assemblyqc_logo_light.png
  • files_unchanged - File ignored due to lint config: docs/images/nf-core-assemblyqc_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-06-04 03:27:48

@GallVp GallVp marked this pull request as draft May 30, 2024 08:49
@GallVp GallVp self-assigned this May 30, 2024
@GallVp GallVp marked this pull request as ready for review June 5, 2024 07:43
@GallVp GallVp merged commit 690e56b into main Jun 5, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment