sets: add Union() #158
Merged
sets: add Union() #158
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
marco-m-pix4d
requested review from
odormond,
iAmoric,
SpectreVert and
aliculPix4D
and removed request for
a team
aliculPix4D
approved these changes
Sep 25, 2024
aliculPix4D
reviewed
Sep 25, 2024
| @@ -105,3 +105,15 @@ func (s *Set[T]) Intersection(x *Set[T]) *Set[T] { | |||
| } | |||
| return result | |||
| } | |||
|
|
|||
| // Union returns a set containing all the elements of s and x. | |||
| func (s *Set[T]) Union(x *Set[T]) *Set[T] { | |||
There was a problem hiding this comment.
Don't you also need the set difference as you wrote in chat? or we already have that...
There was a problem hiding this comment.
Ah we have it...
func (s *Set[T]) Difference(x *Set[T]) *Set[T]
iAmoric
approved these changes
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed for the facchino tags preview.
PCI-3992