cogito: properly encode url #153
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aliculPix4D
requested review from
odormond,
iAmoric,
SpectreVert and
marco-m-pix4d
This was referenced Mar 22, 2024
|
See: the link for autocat (from my local concourse deployment) correctly points to the build. The pipeline was worst case scenario possible: nested json with spaces Sadly, we can't test this better in our Concourse deployment because we don't have |
aliculPix4D
commented
Mar 22, 2024
odormond
approved these changes
Mar 22, 2024
marco-m
approved these changes
Mar 22, 2024
marco-m-pix4d
approved these changes
Mar 25, 2024
SpectreVert
approved these changes
Mar 25, 2024
iAmoric
approved these changes
Mar 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cogito: properly encode url
Actually, the only problem that existed was due the way spaces were encoded. Even the most complex case with nested json worked fine with the existing code. The only thing "missing" was the proper encoding of spaces.
Concourse requires that the space characters are encoded as %20 instead of +. On the other hand golangs url.QueryEscape as well as url.Values.Encode() both encode the space as a + character.
See: golang/go#4013
Fixes: #148