Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(publisher): fix config struct tag for worker component #181

Merged
merged 1 commit into from
Oct 14, 2024

Conversation

wuhuizuo
Copy link
Contributor

Signed-off-by: wuhuizuo [email protected]

@ti-chi-bot ti-chi-bot bot requested a review from purelind October 14, 2024 11:17
Copy link

ti-chi-bot bot commented Oct 14, 2024

I have already done a preliminary review for you, and I hope to help you do a better job.

Summary of changes:

  • Renamed TiPublisher to Publisher.
  • Fixed a struct tag for the Worker component in the config package.
  • Updated usage messages and descriptions to reflect new name.

Potential problems:

  • None found.

Fixing suggestions:

  • None needed. The changes look good.

@ti-chi-bot ti-chi-bot bot added the size/S label Oct 14, 2024
@wuhuizuo
Copy link
Contributor Author

/approve

Copy link

ti-chi-bot bot commented Oct 14, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: wuhuizuo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added the approved label Oct 14, 2024
@ti-chi-bot ti-chi-bot bot merged commit 3db9c25 into main Oct 14, 2024
3 checks passed
@ti-chi-bot ti-chi-bot bot deleted the fix/publisher branch October 14, 2024 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant