Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ktlint -F #766

Merged
merged 4 commits into from
Apr 7, 2024
Merged

ktlint -F #766

merged 4 commits into from
Apr 7, 2024

Conversation

ened
Copy link
Contributor

@ened ened commented Jul 9, 2023

@remonh87

After running ktlint 0.50.0, the files in this PR were changed.

The formatting suggestions seem sensible to me, so I did not add a .editorconfig file.

@ened
Copy link
Contributor Author

ened commented Jan 16, 2024

@Taym95 / @werediver FYI - as preparation for further PRs. May be sensible to add a .github actions extension

@ened
Copy link
Contributor Author

ened commented Jan 16, 2024

Some new formatting changes with ktlint 1.1.1, checking again - pls do not merge

@ened
Copy link
Contributor Author

ened commented Apr 7, 2024

@Taym95 could try to merge this one again, please keep in mind:

  • Doing this will likely break existing PRs that touch the Android codebase
  • .editorconfig was adjusted to keep the refactoring somewhat at bay (line length & field renames), but this should be addressed eventually (and .editorconfig removed again).
  • the GitHub token could get write permissions (or a separate ktlint token), so that the GH action modifies the PR directly

@Taym95
Copy link
Collaborator

Taym95 commented Apr 7, 2024

@Taym95 could try to merge this one again, please keep in mind:

  • Doing this will likely break existing PRs that touch the Android codebase
  • .editorconfig was adjusted to keep the refactoring somewhat at bay (line length & field renames), but this should be addressed eventually (and .editorconfig removed again).
  • the GitHub token could get write permissions (or a separate ktlint token), so that the GH action modifies the PR directly

Yes sounds good, thanks!

@Taym95 Taym95 merged commit e6f04d3 into PhilipsHue:master Apr 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants