Feat: add support for docvalue_fields and stored_fields in TopHitsAggregation #3176
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Philippus
requested changes
Oct 11, 2024
There was a problem hiding this comment.
Stored fields are not the same thing as doc value fields, see https://www.elastic.co/guide/en/elasticsearch/reference/current/search-aggregations-metrics-top-hits-aggregation.html. The existing storedFields field is not used in the builder, so that could be added. If you want to add docValueFields a field would have to be added to the TopHitsAggregation case class and an accompanying docvalueFields method similar to what is done in the InnerHit case class.
paulMConstant
force-pushed
the
paul/main
branch
from
820de83
to
71678e5
Compare
|
Thank you for the quick review. I fixed the |
paulMConstant
changed the title
Philippus
requested changes
Oct 11, 2024
...s-core/src/main/scala/com/sksamuel/elastic4s/requests/searches/aggs/TopHitsAggregation.scala
Outdated
Show resolved
Hide resolved
…ards compatibility
Philippus
approved these changes
Oct 11, 2024
|
Thank you! |
|
Thank you for the quick merge ! |
|
Do you think you could make a release soon ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
It is currently impossible to my understanding to add "docvalue_fields" to a top hits aggregation. Here's a proposition using the storedFields field.
Thanks