Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Multi file support/branches #58

Merged
merged 13 commits into from
Sep 24, 2023
Merged

Multi file support/branches #58

merged 13 commits into from
Sep 24, 2023

Conversation

GreenGitHub99
Copy link
Contributor

@GreenGitHub99 GreenGitHub99 commented Aug 22, 2023

Our first pull request ;)

We added the possibility of splitting code into multiple files.
Imports of the type 'from file import *' will be inlined (like #include in C++ works).
For debugging reasons, the resulting code can (depending on the settings) be saved in the current directory otherwise in the temp directory.

Fix #13

Copy link
Owner

@PeterStaev PeterStaev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @GreenGitHub99 thanks for your contribution! I've added some comments. Also can you please make sure the code is lintified so that the CI builds can pass.

src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated Show resolved Hide resolved
src/extension.ts Outdated
assembledLines=assembledLines.slice(0, index).concat(includedContentSplitted, assembledLines.slice(index));
index--;
continue;
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This continue can be removed from here.

@PeterStaev PeterStaev merged commit 1b034a3 into PeterStaev:master Sep 24, 2023
1 check passed
@JacobenVosloo
Copy link

See issue created relevant to this MR - #66

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Ability to upload multiple/all project files in one go
4 participants