Fowler Brothers translation #1490
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AlisonBabeu
reviewed
Aug 10, 2023
| <fileDesc> | ||
| <titleStmt> | ||
| <title xml:lang="eng">Dionysus, an Introductory Lecture</title> | ||
| <sponsor>Tufts University</sponsor> |
There was a problem hiding this comment.
We would normally also include the author and editor/translator name up here as well
|
hi @gregorycrane from a quick look at this pull request you need to update all the cts_.xml files so that they include these new translations that you had added. |
AlisonBabeu
reviewed
Aug 10, 2023
| </encodingDesc> | ||
| <profileDesc> | ||
| <langUsage> | ||
| <language ident="en">English</language> |
AlisonBabeu
reviewed
Aug 10, 2023
|
|
||
| <p><label>Purist</label> I give it up from this moment.</p> | ||
|
|
||
| <p><label>Lycinus</label> Then we will break off for the present, and take the rest another time H. and F. |
There was a problem hiding this comment.
I noticed that most of the translations have H. or F. or H. and F. at the end, I imagine to indicate which or both of the brothers that translated the work,but I was wondering should that be included?
There was a problem hiding this comment.
Quite Right! I had been putting off encoding them. We can't use the data yet but they will be encoded as <docAuthor/>
|
Fixed Alison's suggestions. On to the next batch! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#1489