Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump Devel-PPPort and recover patches from repo #21453

Merged
merged 1 commit into from
Sep 12, 2023
Merged

Conversation

atoomic
Copy link
Member

@atoomic atoomic commented Sep 4, 2023

Apply to blead multiple patches only available on the D-PPP GitHub repo.

  • Bump INT_MAX_PERL to version 5038000
  • Fix sv_2pv and sv_2pv_flags for Perl < 5.17.2
  • Change github clone URL from git:// to https://
  • Teach scanprov about --skip-devels
  • Use REDEFINE in more parts/inc/misc locations

Copy link
Contributor

@khwilliamson khwilliamson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@pali, there are things for you here.

dist/Devel-PPPort/parts/inc/SvPV Outdated Show resolved Hide resolved
dist/Devel-PPPort/parts/inc/SvPV Outdated Show resolved Hide resolved
dist/Devel-PPPort/parts/inc/SvPV Outdated Show resolved Hide resolved
@atoomic atoomic force-pushed the d-ppp-72 branch 2 times, most recently from fe8b1e6 to 1bee553 Compare September 11, 2023 15:40
atoomic added a commit to atoomic/Devel-PPPort that referenced this pull request Sep 11, 2023
Apply several fixes after review while submitting
changes from this repo to blead.

Upstream-URL: Perl/perl5#21453
dist/Devel-PPPort/parts/inc/SvPV Outdated Show resolved Hide resolved
Apply to blead multiple patches only available on the
D-PPP GitHub repo.

* Bump INT_MAX_PERL to version 5038000
* Fix sv_2pv and sv_2pv_flags for Perl < 5.17.2
* Change github clone URL from git:// to https://
* Teach scanprov about --skip-devels
* Use __REDEFINE__ in more parts/inc/misc locations

Extra fixes after review:
* Add link to GitHub issue for sv_2pv fix for Perl < 5.7.2
* Prefer using 'PERL_USE_GCC_BRACE_GROUPS' check instead
of PERL_GCC_BRACE_GROUPS_FORBIDDEN
* Stop using PL_na for sv_2pv_flags and sv_2pv_flags
@atoomic atoomic merged commit 91497b7 into Perl:blead Sep 12, 2023
27 of 28 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants