Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adding an option to close PerimeterX #291

Merged
merged 1 commit into from
Apr 27, 2023
Merged

Adding an option to close PerimeterX #291

merged 1 commit into from
Apr 27, 2023

Conversation

guyeisenbach
Copy link
Contributor

This PR should solve the issue: #121

To properly close the resources use pxFilter.close() as shown in the example.

ori-gold-px
ori-gold-px approved these changes Apr 27, 2023
View reviewed changes
Copy link
Contributor

@ori-gold-px ori-gold-px left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Was debating between letting the error bubble up or catching it within PXFilter -- but I think bubbling it up is the right call.

@guyeisenbach guyeisenbach merged commit baf8c06 into dev Apr 27, 2023
@guyeisenbach guyeisenbach deleted the bugfix/SDKNEW-2781-closing-resources branch April 27, 2023 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ori-gold-px ori-gold-px ori-gold-px approved these changes

@chen-zimmer-px chen-zimmer-px Awaiting requested review from chen-zimmer-px

@etrpx etrpx Awaiting requested review from etrpx

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@guyeisenbach @ori-gold-px