feat: Frax Debt/Collateral adaptors + permission updates #223
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrit
requested review from
EricBolten,
51N84D,
josephterrigno and
crispymangoes
EricBolten
reviewed
Sep 19, 2023
|
|
||
| // Represents function `addCollateral(IFToken _fraxlendPair, uint256 _collateralToDeposit)` | ||
| AddCollateral add_collateral = 2; | ||
| // Represents function `removeCollateral(uint256 _collateralAmount, IFToken _fraxlendPair)` |
There was a problem hiding this comment.
Maybe a dumb question but sanity checking: all the other Fraxlend functions start with the IFToken, is this an error or just an anomaly?
There was a problem hiding this comment.
they just changed the param name in the latest contracts, they are still address underneath
There was a problem hiding this comment.
I was referring to the order in the function call rather than the IFToken type.
josephterrigno
approved these changes
Sep 19, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.