Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RYETH/BTC allow Aave V3 adaptor for RYETH/BTC, Cellar adaptor for RYBTC, cachePriceRouter function #221

Merged
merged 6 commits into from
Sep 12, 2023
Merged

RYETH/BTC allow Aave V3 adaptor for RYETH/BTC, Cellar adaptor for RYBTC, cachePriceRouter function #221

merged 6 commits into from
Sep 12, 2023

Conversation

cbrit
Copy link
Member

@cbrit cbrit commented Sep 11, 2023

Note the cellar v2.2 ABI file changed, but the only strategist function affected was cachePriceRouter which is why it was necessary. Somehow RYETH was on a newer version of the ABI than we had in the repo.

@cbrit cbrit changed the base branch from main to 3.x-main September 11, 2023 21:25
@cbrit cbrit changed the title RYETH/BTC Aave V3 adaptor change + cachePriceRouter function RYETH/BTC Aave V3 adaptor change for RYETH/BTC, Cellar adaptor change for RYBTC, cachePriceRouter function Sep 11, 2023
@cbrit cbrit changed the title RYETH/BTC Aave V3 adaptor change for RYETH/BTC, Cellar adaptor change for RYBTC, cachePriceRouter function RYETH/BTC allow Aave V3 adaptor for RYETH/BTC, Cellar adaptor for RYBTC, cachePriceRouter function Sep 11, 2023
EricBolten
EricBolten reviewed Sep 11, 2023
View reviewed changes
Copy link
Contributor

@EricBolten EricBolten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some questions and comments.

proto/cellar_v2.proto Outdated Show resolved Hide resolved
steward/src/cellars.rs Show resolved Hide resolved
steward/src/cellars/cellar_v2_2.rs Show resolved Hide resolved
steward/src/cellars.rs Outdated Show resolved Hide resolved
@cbrit cbrit temporarily deployed to CI September 12, 2023 16:14 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI September 12, 2023 16:14 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI September 12, 2023 16:14 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI September 12, 2023 17:13 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI September 12, 2023 17:13 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI September 12, 2023 17:13 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI September 12, 2023 17:13 — with GitHub Actions Inactive
EricBolten
EricBolten approved these changes Sep 12, 2023
View reviewed changes
Copy link
Contributor

@EricBolten EricBolten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricBolten EricBolten merged commit bb7d4eb into 3.x-main Sep 12, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricBolten EricBolten EricBolten approved these changes

@51N84D 51N84D Awaiting requested review from 51N84D

@josephterrigno josephterrigno Awaiting requested review from josephterrigno

@crispymangoes crispymangoes Awaiting requested review from crispymangoes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbrit @EricBolten