Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SetSharePriceOracle for turbo sweth #220

Merged
merged 5 commits into from
Sep 1, 2023
Merged

SetSharePriceOracle for turbo sweth #220

merged 5 commits into from
Sep 1, 2023

Conversation

cbrit
Copy link
Member

@cbrit cbrit commented Sep 1, 2023

No description provided.

EricBolten
EricBolten reviewed Sep 1, 2023
View reviewed changes
Copy link
Contributor

@EricBolten EricBolten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some comments and questions.

steward/src/cellars/cellar_v2_5.rs Outdated Show resolved Hide resolved
steward/src/cellars/cellar_v2_5.rs Outdated Show resolved Hide resolved
steward_proto_rust/src/prost/steward.v3.rs Show resolved Hide resolved
@cbrit cbrit temporarily deployed to CI September 1, 2023 19:23 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI September 1, 2023 19:23 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI September 1, 2023 19:23 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI September 1, 2023 19:23 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI September 1, 2023 20:12 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI September 1, 2023 20:12 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI September 1, 2023 20:12 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI September 1, 2023 20:12 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI September 1, 2023 21:14 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI September 1, 2023 21:14 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI September 1, 2023 21:14 — with GitHub Actions Inactive
@cbrit cbrit temporarily deployed to CI September 1, 2023 21:14 — with GitHub Actions Inactive
EricBolten
EricBolten approved these changes Sep 1, 2023
View reviewed changes
Copy link
Contributor

@EricBolten EricBolten left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@EricBolten EricBolten merged commit b1f9894 into 3.x-main Sep 1, 2023
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricBolten EricBolten EricBolten approved these changes

@crispymangoes crispymangoes Awaiting requested review from crispymangoes

@0xEinCodes 0xEinCodes Awaiting requested review from 0xEinCodes

@josephterrigno josephterrigno Awaiting requested review from josephterrigno

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@cbrit @EricBolten