Collin/queries #22
Merged
Collin/queries #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cbrit
requested review from
zmanian,
EricBolten,
jackzampolin,
philipjames44 and
tony-iqlusion
cbrit
commented
Mar 16, 2022
| } | ||
|
|
||
| Ok(uri.to_string()) | ||
| } |
There was a problem hiding this comment.
I think this method is sketchy and would appreciate some feedback on it @EricBolten @tony-iqlusion
philipjames44
approved these changes
Mar 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Establishes cosmos module exposure with convenient rust module wrapping
Exposes module query clients with convenience type wrappers
Implements convenience methods for basic bank queries
Unit/integration tests
Closes #5