Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PADV-1341: Improve LTI AGS score publish code #37

Merged
merged 1 commit into from
Jun 5, 2024
Merged

Conversation

kuipumu
Copy link
Contributor

@kuipumu kuipumu commented May 24, 2024

Tickets

Description

This PR adds various improvements to the LTI AGS score publish code, more specifically to the code responsible of sending the request to the LTI platform AGS score publish service endpoint and the code responsible for sending score updates for LTI launches using the LTI AGS service on graded courses.

Type of Change

  • Rename the signal receiver update_course_score to publish_course_score.
  • Remove unnecesary code from the publish_course_score receiver.
  • Add logging to publish_course_score receiver.
  • Rename update_score method from LtiGradedResource model to publish_score.
  • Add try/except block to LTI AGS publish score request.
  • Add logging to the publish_score method.
  • Add or modify any unit test for all related code.

@kuipumu kuipumu self-assigned this May 24, 2024
@kuipumu kuipumu changed the title PADV-1341: Fix AGS update_course_score signal PADV-1341: Improve LTI AGS score publish code May 29, 2024
@kuipumu kuipumu merged commit ea0e42c into main Jun 5, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants