fix: courseware-chromeless.html iframe height #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kuipumu
force-pushed
the
kuipumu/fix-courseware-iframe-heigth
branch
from
9c73788
to
44d1c52
Compare
Serafin-dev
requested changes
Oct 1, 2024
| var lastHeight = window.offsetHeight; | ||
| // An extra 250 height is added to make sure the iframe height | ||
| // is enough in case a maintance banner is added to the iframe. | ||
| var lastHeight = window.offsetHeight + 250; |
There was a problem hiding this comment.
Hi @kuipumu . Have you considered document.body.scrollHeight instead of setting an arbitrary value?
There was a problem hiding this comment.
@Serafin-dev I tried using scrollHeight but it doesn't seem to work, ¿did you tested locally?
There was a problem hiding this comment.
yes, but same happened to me. If this solves the issue it is ok.
Serafin-dev
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds a fix to the courseware-chromeless.html template, this template is used to render the XBlock on the learning MFE in an Iframe, this template contains a JavaScript code that sends a postMessage to the parent window that is used by the learning MFE to resize the Iframe to the heigth of its content, on the initial load of the Iframe the height is incorrectly calculated when the maintenance banner is added to the unit content, to fix this an extra 250px is added to the calculated height of the Iframe.