-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve how ParselyTracker
is accessed
#105
Commits on Jan 18, 2024
-
feat: introduce
ParselyTracker#init
To clearly distinguish initialization method from getting tracker instance method.
Configuration menu - View commit details
-
Copy full SHA for 17011a5 - Browse repository at this point
Copy the full SHA 17011a5View commit details -
feat: remove
sharedInstance
methodAnd move all methods invocations to static `ParselyTracker`. Throw exception if using `ParselyTracker` methods without prior `init`
Configuration menu - View commit details
-
Copy full SHA for 9ca9989 - Browse repository at this point
Copy the full SHA 9ca9989View commit details -
Configuration menu - View commit details
-
Copy full SHA for 0243576 - Browse repository at this point
Copy the full SHA 0243576View commit details -
Configuration menu - View commit details
-
Copy full SHA for fa1771a - Browse repository at this point
Copy the full SHA fa1771aView commit details
Commits on Jan 19, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 35e9cdd - Browse repository at this point
Copy the full SHA 35e9cddView commit details
Commits on Jan 23, 2024
-
Configuration menu - View commit details
-
Copy full SHA for 96d3fe9 - Browse repository at this point
Copy the full SHA 96d3fe9View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1ddfda1 - Browse repository at this point
Copy the full SHA 1ddfda1View commit details -
fix: do not add
@Throws
annotation toensureInitialized
It's `private` method, not exposed to the client so there's no point in adding this annotation. Also, I don't add it to public methods because I don't want force clients to handle exception each time they want to call SDK.
Configuration menu - View commit details
-
Copy full SHA for 451d061 - Browse repository at this point
Copy the full SHA 451d061View commit details -
tests: add unit tests for
ParselyTracker
initializationThe `ParselyTracker#tearDown` method was added as singleton persisted between unit tests, causing some of them to fail. I could introduce a similar behavior using reflection, but I believe `internal tearDown` method is cleaner and is not problematic as not exposed to the client
Configuration menu - View commit details
-
Copy full SHA for 0478d9e - Browse repository at this point
Copy the full SHA 0478d9eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 1e293df - Browse repository at this point
Copy the full SHA 1e293dfView commit details -
Configuration menu - View commit details
-
Copy full SHA for b23113a - Browse repository at this point
Copy the full SHA b23113aView commit details -
style: move
ParselyNotInitializedException
message to exception itselfTo align with other exception and move responsibility from `ParselyTracker`
Configuration menu - View commit details
-
Copy full SHA for cf9843d - Browse repository at this point
Copy the full SHA cf9843dView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f6c637 - Browse repository at this point
Copy the full SHA 9f6c637View commit details
Commits on Jan 24, 2024
-
feat: bring back
ParselyTracker
interfaceAnd `ParselyTracker#sharedInstance` method. Allows consumer clients to mock the `ParselyTracker` interface in their tests.
Configuration menu - View commit details
-
Copy full SHA for fa7a23e - Browse repository at this point
Copy the full SHA fa7a23eView commit details
Commits on Jan 29, 2024
-
Configuration menu - View commit details
-
Copy full SHA for bc2b23e - Browse repository at this point
Copy the full SHA bc2b23eView commit details -
fix:
sharedInstance
should returnParselyTracker
interfaceInstead of internal class `ParselyTrackerInternal`
Configuration menu - View commit details
-
Copy full SHA for 4fe2b08 - Browse repository at this point
Copy the full SHA 4fe2b08View commit details -
docs: move javadoc comments from internal class to interface
So they're easily visible for consumers
Configuration menu - View commit details
-
Copy full SHA for c45ef7b - Browse repository at this point
Copy the full SHA c45ef7bView commit details