Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Updated chat schema #2466
base: develop
Are you sure you want to change the base?
Updated chat schema #2466
Changes from 66 commits
a8c02f8
fe6907d
3a9799d
2fa65b1
f68bb01
f7089b9
2fe5353
7e31c14
0bf28a2
9c44ea4
fa5f6ec
3db8381
a1379bf
bd98a6b
7ec1773
3781ede
8aaf5f3
e83657d
23a9676
9576d4a
c2af22d
ad48619
77c7fde
d18843a
cf27ca6
8469653
87ad70f
33535ac
98d06a7
5a61b43
a84f1c6
4d65b03
c23008b
a539e3e
074b79c
9926e63
1586732
8b873ea
15d6bed
46d4f5f
ce20fe0
dcd6006
ea23279
ff1987f
7cd8040
f29ac65
a440bad
615a5ac
5ad1d76
c2d831a
bac5283
a2e5141
39d9086
d450059
aad9ea2
b5da053
50d579e
99a24c2
23ba0b5
c4f6cd6
3b0f12c
9f2f12d
a6b960f
8548f25
bf38bc6
d42aca6
4124a3a
7d5667d
9911641
3b4e431
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use
MessageType
enum fortype
parameter insendMessageToChat
mutation.Replacing the
String
type with theMessageType
enum for thetype
parameter enhances validation and ensures only predefined message types are accepted.Define the
MessageType
enum:Apply this diff:
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Include 'organizationId' and 'userIds' in 'chatInput' for completeness
The
chatInput
type appears incomplete. To support organization-specific chats and specify participants, includeorganizationId
anduserIds
fields.Apply this diff:
Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Use lowercase
string
for type consistency.The
String
type should be replaced withstring
to adhere to TypeScript best practices.Use this diff to fix the types: