Dev/adjust tcn coco saving #460
Open
+127
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Purg
reviewed
Oct 23, 2024
…when it decides not to create a classification
Purg
reviewed
Oct 25, 2024
Purg
reviewed
Oct 25, 2024
ros/angel_system_nodes/angel_system_nodes/activity_classification/activity_classifier_tcn.py
Outdated
Show resolved
Hide resolved
Purg
reviewed
Oct 25, 2024
Comment on lines
+197
to
+198
| and self.frames[-1][2] == image_frame_number | ||
| and time_to_int(img_header_stamp) <= time_to_int(self.frames[-1][0]) |
There was a problem hiding this comment.
Were we getting situations where different frames had the same timestamp?
There was a problem hiding this comment.
Yes, although I'm not sure if this is only an artifact of playing a bag that was created with our script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adjusts the saving of the coco file from the TCN ros node so that the annotations are in the annotation section instead of in the images