Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Microsimulation fixes #35

Merged
merged 9 commits into from
Nov 29, 2021
Merged

Conversation

nikhilwoodruff
Copy link
Collaborator

This PR:

  • Improves, documents and adds tests for code in get_micro_data.py (mainly the household MTR function)
  • Should fix @jpycroft's last issue in Error running the example script #31 (the synthetic dataset isn't automatically downloading)
  • Fixes the example script to run by default

@nikhilwoodruff nikhilwoodruff self-assigned this Nov 29, 2021
@nikhilwoodruff
Copy link
Collaborator Author

Here are the outputs produced by examples/plot.py now (the tax functions in 3D plots):
image
image
image

@codecov
Copy link

codecov bot commented Nov 29, 2021

Codecov Report

Merging #35 (6a148c1) into main (857532c) will increase coverage by 17.26%.
The diff coverage is 100.00%.

Impacted file tree graph

@@             Coverage Diff             @@
##             main      #35       +/-   ##
===========================================
+ Coverage   45.85%   63.12%   +17.26%     
===========================================
  Files           6        4        -2     
  Lines         205      141       -64     
===========================================
- Hits           94       89        -5     
+ Misses        111       52       -59     
Flag Coverage Δ
unittests 63.12% <100.00%> (+17.26%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
oguk/get_micro_data.py 70.96% <100.00%> (-5.35%) ⬇️
oguk/tests/test_get_micro_data.py 87.50% <100.00%> (+3.62%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 857532c...6a148c1. Read the comment docs.

@jdebacker
Copy link
Member

@nikhilwoodruff Thanks for this PR. LGTM. Merging.

@jdebacker jdebacker merged commit 75c844c into PSLmodels:main Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants