fixes from rens' PR comments

PRIME-TU-Delft · Aug 29, 2023 · bc4a810 · bc4a810
1 parent 4dfb32b
commit bc4a810
Show file tree

Hide file tree

Showing 22 changed files with 16 additions and 985 deletions.
diff --git a/svelte-app/package.json b/svelte-app/package.json
@@ -44,7 +44,6 @@
 		"@threlte/extras": "^5.0.1",
 		"aframe": "^1.4.2",
 		"gammacv": "^0.5.3",
-		"imagetracerjs": "^1.2.6",
 		"mdi-svelte-ts": "^1.0.0",
 		"opencv-ts": "^1.3.6",
 		"p5": "^1.7.0",

diff --git a/svelte-app/src/lib/components/Video.svelte b/svelte-app/src/lib/components/Video.svelte
@@ -26,7 +26,7 @@
 		try {
 			stream = await navigator.mediaDevices.getUserMedia({ video: constraints });
 
-			// TODO: set stream id to deviceId
+			deviceId = stream.getVideoTracks()[0].getSettings().deviceId || '';
 
 			loading = false;
 			error = '';

diff --git a/svelte-app/src/routes/capture/-page.svelte b/svelte-app/src/routes/capture/-page.svelte
diff --git a/svelte-app/src/routes/crop/gamma-cv/inverseKernel.glsl b/svelte-app/src/routes/crop/gamma-cv/inverseKernel.glsl
@@ -1,3 +1,4 @@
+// Kernel for inverting the colors of an image
 vec4 operation(float y, float x) {
   vec4 data = pickValue_tSrc(y, x);
 

diff --git a/svelte-app/src/routes/crop/open-cv/imageToContours.ts b/svelte-app/src/routes/crop/open-cv/imageToContours.ts
@@ -2,7 +2,7 @@ import { contourLines } from '$lib/stores/contourLineStore';
 import { matCVToContourHierarchy, getCurvesFromContourHierarchy, detectCurvesFromCanvas } from './detectCurves';
 
 /**
- * Draws the provided curves on the provided canvas.
+ * Draws debug lines curves on the provided canvas.
  * @param canvas Debug canvas
  * @param curves Curves to draw
  */

diff --git a/svelte-app/src/routes/crop/p5/SnapCenter.ts b/svelte-app/src/routes/crop/p5/SnapCenter.ts
@@ -5,8 +5,10 @@
 import type p5 from 'p5';
 import SnapMember from './SnapMember';
 import type SnapCorner from './SnapCorner';
-import type SnapEdge from './SnapEdge';
 
+/**
+ * This class represents the center of the crop area. It is used to translate the entire the crop area around.
+ */
 export default class SnapCenter extends SnapMember {
 
     constructor(p5: p5, id: string, a: SnapCorner, b: SnapCorner, c: SnapCorner, d: SnapCorner) {

diff --git a/svelte-app/src/routes/crop/p5/SnapCorner.ts b/svelte-app/src/routes/crop/p5/SnapCorner.ts
@@ -7,6 +7,9 @@ import SnapMember from './SnapMember';
 import type SnapEdge from './SnapEdge';
 import type SnapCenter from './SnapCenter';
 
+/**
+ * This class represents the corners of the crop area. It is used to resize the crop area.
+ */
 export default class SnapCorner extends SnapMember {
 
     constructor(p5: p5, id: string, vec: { x: number, y: number }) {

diff --git a/svelte-app/src/routes/crop/p5/SnapEdge.ts b/svelte-app/src/routes/crop/p5/SnapEdge.ts
@@ -3,9 +3,12 @@
  */
 
 import type p5 from 'p5';
-import SnapMember from './SnapMember';
 import type SnapCorner from './SnapCorner';
+import SnapMember from './SnapMember';
 
+/**
+ * This class represents the edges of the crop area. It is used to resize the crop area.
+ */
 export default class SnapEdge extends SnapMember {
 
     constructor(p5: p5, id: string, a: SnapCorner, b: SnapCorner) {

diff --git a/svelte-app/src/routes/crop/p5/SnapMember.ts b/svelte-app/src/routes/crop/p5/SnapMember.ts
@@ -4,6 +4,9 @@
 
 import type p5 from 'p5';
 
+/**
+ * This class represents a member of the crop area. It is used to resize the crop area.
+ */
 export default class SnapMember {
 
     id: string;