Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md #45

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #45

wants to merge 1 commit into from

Conversation

CmptAdam
Copy link

@CmptAdam CmptAdam commented Apr 3, 2018

This file has been edited by a Computer Science student in a Technical Writing course. The students are tasked in finding online real-world documentation to edit. Full marks are achieved if the original author of the work accepts the changes; in this case a Pull Request.
Please review and accept the Pull Request and thank you so much!

This file has been edited by a Computer Science student in a Technical Writing course. The students are tasked in finding online real-world documentation to edit. Full marks are achieved if the original author of the work accepts the changes; in this case a Pull Request.
Please review and accept the Pull Request and thank you so much!
@garrettw
Copy link

garrettw commented Apr 3, 2018

This is not an improvement; there are numerous grammatical errors. Here are a few big ones:

  • "Reason why that" is wrong; should be "reason that"
    • The correct grammar for a "reason" clause is "The reason that (something is true) is (explanation)."
  • "PHPixie" should not have "the" in front of it when used as a noun
  • ", therefore;" is never right; should be "; therefore,"

If you make a new commit with some fixes, it will automatically show up here so it can be accepted.

@garrettw garrettw mentioned this pull request Apr 3, 2018
@garrettw
Copy link

garrettw commented Apr 3, 2018

Please close either this PR or your other one. Two are not necessary for changes to the same thing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants