Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #35: Removendo contantes de configuração. #37

Open
wants to merge 9 commits into
base: master
Choose a base branch
from
Open

Fixes #35: Removendo contantes de configuração. #37

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c6b06c2
Removendo contantes de configuração.
Dec 29, 2016
ffc48f9
Merge branch 'master' into feature/removes-config-contants
enieber Feb 8, 2017
f319875
Ajustando classe com sugestoes do @malukenho
EvandroMohr Jun 18, 2017
859d7a5
Refatorando para separar responsabilidades
EvandroMohr Jun 18, 2017
17c9a30
Refatorando para separar responsabilidades, corrigindo chamada de mét…
EvandroMohr Jun 18, 2017
483a99c
Refatorando método de geração do banco de dados para 2 métodos difere…
EvandroMohr Jun 18, 2017
949e131
Update check-environment.phpt
EvandroMohr Jun 18, 2017
5ab5ae5
Marcando como @todo para remover isso mais pra frente
EvandroMohr Jun 18, 2017
0c83bb4
Update check-environment.phpt
EvandroMohr Jun 18, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
26 changes: 13 additions & 13 deletions src/Factory/AppFactory.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@
namespace PseudoORM\Factory;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sth?


use PseudoORM\Entity\EntidadeBase;
use PseudoORM\DAO\GenericDAO;
use \Exception;

class AppFactory
Expand Down Expand Up @@ -33,17 +32,18 @@ public static function getFactory()

public static function getRepository(EntidadeBase $objeto)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Return type?

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is it static?

{
try {
$class = get_class($objeto);
$respositoryPath = DAOS . $class . 'DAO.php';
if (!file_exists($respositoryPath)) {
return new GenericDAO($class);
}
require_once $respositoryPath;
$repository = $class . 'DAO';
return new $repository;
} catch (Exception $e) {
throw new Exception($e->getMessage());
}
$class = get_class($objeto);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ya don't need to get the name of class, just use ReflectionObject instead.

$classShortName = (new \ReflectionClass($objeto))->getShortName();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no caso dessas ReflectionClass a função vai pegar o nome da classe ao invés de precisar fazer um require_once ?


$classDAO = '\\PseudoORM\\DAO\\' . $classShortName . 'DAO';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should a DI be used instead?


$entityName = class_exists($classDAO)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What if my repository is an anonymous class?

? $classShortName
: 'Generic'
;

$repository = '\\PseudoORM\\DAO\\' . $entityName . 'DAO';
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Repositories should be configured in some kind of mapping file — xml? —


return new $repository($class);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what if $repository isn't a valid class?

}
}
4 changes: 0 additions & 4 deletions test/functional/check-environment.phpt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,6 @@ define('ENCODING', "SET NAMES 'utf8';");
define("DB_DSN", "pgsql:host=".DB_HOST.";port=".DB_PORT.";dbname=".DB_NAME.";");
define("SHOW_SQL_ERROR", PDO::ERRMODE_EXCEPTION);
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe mark this constants to be removed in the future as well? @todo ?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

marquei como @todo


define('MODELS', '../app/models/');
define('DAOS', MODELS . 'DAO/impl/');
define('EXCEPTIONS', MODELS . 'exception/');

use PseudoORM\Entity\Usuario;
use PseudoORM\Factory\AppFactory;
use PseudoORM\Services\PostgreSQLDataBaseCreator;
Expand Down