Replace Odeint with in-house Runge-Kutta 4th order #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Copy work from PCMSolver/pcmsolver#138 See also previous discussion there.
Description
This PR removes the dependency on Odeint by providing code for a Runge-Kutta 4th order integrator.
In addition, the code for handling the radial solutions and some of the internals of the
SphericalDiffuseclass have been significantly simplified.How Has This Been Tested?
All unit tests but one pass.
green_spherical_diffuse, which checks the value of the Green's function. However, the tests on boundary integral operators and IEF pass without any tweak. It seems to me some loss of accuracy happens with the new integrator, but I cannot see how that could happen given that the Butcher tableau used by Odeint is the same as mine.Todos
Questions
Status