Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chores: add analytics script tag #168

Merged
merged 4 commits into from
Jul 9, 2023
Merged

chores: add analytics script tag #168

merged 4 commits into from
Jul 9, 2023

Conversation

SirusCodes
Copy link
Member

No description provided.

@SirusCodes SirusCodes requested a review from a team July 1, 2023 11:21
public/html/index.html Outdated Show resolved Hide resolved
@KartikSoneji
Copy link
Member

Can we have metrics of how many times each summary was read, and how much did people scroll on the combined summary page?

@SirusCodes
Copy link
Member Author

It has number of times summary was read individual page

We might need to add custom code to dispatch events for scroll but there is nothing inbuilt.

@KartikSoneji
Copy link
Member

It has number of times summary was read individual page

Yes but can we add the summary number too?
And can we modify the templates to track how many times each summary was opened?

We might need to add custom code to dispatch events for scroll but there is nothing inbuilt.

Hmm we can do something with the IntersectionObserver API.

@SirusCodes
Copy link
Member Author

Yes but can we add the summary number too? And can we modify the templates to track how many times each summary was opened?

It will give us times a page was viewed... so /summary/123 is self-explanatory.

Hmm we can do something with the IntersectionObserver API.

Yeah, but that can be another PR or maybe a PR directly into https://github.com/umami-software/umami?

@KartikSoneji
Copy link
Member

KartikSoneji commented Jul 2, 2023

Hmm we can do something with the IntersectionObserver API.

Yeah, but that can be another PR or maybe a PR directly into https://github.com/umami-software/umami?

Good idea, do they have an open feature request for anything similar?
While you're there, see if they have anything about making the analytics public.

@SirusCodes
Copy link
Member Author

Good idea, do they have an open feature request for anything similar?

Couldn't find one... if you can please open one.

While you're there, see if they have anything about making the analytics public.

We can create a public url sharing link... idk if it's a good idea to do so.

@KartikSoneji
Copy link
Member

While you're there, see if they have anything about making the analytics public.

We can create a public url sharing link... idk if it's a good idea to do so.

Why not?
We are not going to monetize anything so I don't think we have anything to hide.

@KartikSoneji
Copy link
Member

Also, please rebase on main.

@SirusCodes SirusCodes merged commit 7c75e13 into main Jul 9, 2023
3 checks passed
@SirusCodes SirusCodes deleted the analytics branch July 9, 2023 20:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants