Feat remove duplicate title #101
Conversation
SaketThota
commented
Oct 21, 2022
SaketThota
commented
- Made the main title hyperlink
- Removed duplicate title
| @@ -0,0 +1,468 @@ | |||
| <!DOCTYPE html> | |||
| <html lang="en"> | |||
There was a problem hiding this comment.
@SaketThota I don't think you meant to commit this, please amend your commits to remove it.
| @@ -1,6 +1,4 @@ | |||
| = OTC CatchUp Summaries | |||
| Our Tech Community | |||
There was a problem hiding this comment.
It won't matter much but why are we removing this?
There was a problem hiding this comment.
Yeah I don't think we should remove that line. That is the author of the page.
| @@ -1,4 +1,4 @@ | |||
| = OTC CatchUp #{catchup_display_number} Summary | |||
| = link:/summary/{catchup_display_number}[OTC CatchUp #{catchup_display_number} Summary] | |||
There was a problem hiding this comment.
Who would click on this link?
There was a problem hiding this comment.
Yeah this is not required in the individual summary.
| @@ -1,11 +1,12 @@ | |||
| [#{catchup_display_number}] | |||
| === link:/summary/{catchup_display_number}[OTC CatchUp #{catchup_display_number}] | |||
| :leveloffset: -1 | |||
| [#{catchup_display_number}] | ||
| === link:/summary/{catchup_display_number}[OTC CatchUp #{catchup_display_number}] |
There was a problem hiding this comment.
As far as I remember we don't need to make any changes in this
There was a problem hiding this comment.
Yes, this needs to be kept in.
| @@ -71,6 +71,7 @@ done; | |||
| # Build combined summary site | |||
| asciidoctor \ | |||
| -a webfonts! \ | |||
| -a building_combined_summary \ | |||
|
@SaketThota are you still working on this? |
I think I fixed the problem of having double lines before About OTC . |
|
Okay I am really confused. Is this PR still valid @SirusCodes? |
|
The issue is not fixed... So yeah it is valid. @SaketThota you are still working on it? |
|
I am not currently not working on it, but would like to take it up later. |
|
I think it would be better to open a new PR at this point. There are too many unnecessary changes here. |
|
What's the status/updates of this PR? |
|
@SaketThota @SirusCodes pinging y'all to look into this PR. |
|
I will handle it in #113 |
|
Okay, then I'm closing this PR. |
