Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deploy Base Timelock #441

Merged
merged 1 commit into from
Sep 5, 2024
Merged

Deploy Base Timelock #441

merged 1 commit into from
Sep 5, 2024

Conversation

shahthepro
Copy link
Collaborator

Deployments


If you made a contract change, make sure to complete the checklist below before merging it in master.

Contract change checklist:

  • Code reviewed by 2 reviewers.
  • Copy & paste code review security checklist below this checklist.
  • Unit tests pass
  • Slither tests pass with no warning
  • Echidna tests pass if PR includes changes to OUSD contract (not automated, run manually on local)

Copy link

@clement-ux clement-ux left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • All deployed contracts are listed in the deploy PR's description
    • Timelock
  • Deployed contract's verified code (and all dependencies) match the code in master
    • Timelock
  • The transactions that interacted with the newly deployed contract match the deploy script.
    • No transactions.
  • Governance proposal matches the deploy script.
    • No governance proposal.

Contract Diff

  • Timelock
sol2uml diff 0xf817cb3092179083c48c014688D98B72fB61464f .,node_modules -n base

(node:31942) ExperimentalWarning: The Fetch API is an experimental feature. This feature could change at any time
(Use `node --trace-warnings ...` to show where the warning was created)


changed contracts/Timelock.sol
removed lib/openzeppelin-contracts/contracts/access/AccessControl.sol
removed lib/openzeppelin-contracts/contracts/access/IAccessControl.sol
removed lib/openzeppelin-contracts/contracts/governance/TimelockController.sol
removed lib/openzeppelin-contracts/contracts/utils/Context.sol
removed lib/openzeppelin-contracts/contracts/utils/introspection/ERC165.sol
removed lib/openzeppelin-contracts/contracts/utils/introspection/IERC165.sol
removed lib/openzeppelin-contracts/contracts/utils/Strings.sol

Copy link
Member

@sparrowDom sparrowDom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks for making the preparations for multichain support

@sparrowDom
Copy link
Member

🟢 The contract deployed to 0xf817cb3092179083c48c014688d98b72fb61464f matches the source code in this repo

@shahthepro shahthepro merged commit 59b2db0 into master Sep 5, 2024
2 of 4 checks passed
@shahthepro shahthepro deleted the shah/deploy-base-timelock branch September 5, 2024 07:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants