Do Governance Proposals with Signatures #429
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DanielVF
changed the title
0xemagic
reviewed
May 31, 2024
There was a problem hiding this comment.
need to add the description for the functions and parameters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our governance contract has two different
proposemethods. One tracks the plain text signatures of called methods, and the other does not. We want to switch to using the signature based method for governance, since this makes verification easier, and our tooling is already built to use it.Before:
propose(address[],uint256[],bytes[],string)After:
propose(address[],uint256[],string[],bytes[],string)