fix: set adapter search suffixes correctly with DCO #306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
this patch requires #305, otherwise guid will be empty |
|
@lstipakov could you also review this? We deployed that patch at a large user base. Search domains works just like with Wintun, we don't see any degradation. |
|
Anyone? |
|
Sorry for the delay. This DNS handling has been recently heavily refactored. It is likely that this feature has already been implemented. Please ping us if it is not. |
|
We are using 3.9 internally already, but with this patch still applied. I didn't see it working without it. |
|
I will recheck, as I see |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on discussion in OpenVPN/openvpn#326