Add a global option to always prompt for OTP #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a checkbox to the general settings menu to always prompt for OTP when prompting for password even if no static-challenge request is received from the management interface. The response is appeneded to the password using the concatenation format and submitted to the management interface. Signed-off-by: Selva Nair <[email protected]>
Signed-off-by: Selva Nair <[email protected]>
selvanair
force-pushed
the
concat-global
branch
from
528966e
to
6783ca2
Compare
|
Anyone thinks this is useful? After hearing that tunnelblick has had such a feature for years I'm more sympathetic to users request for this. |
lstipakov
approved these changes
Sep 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is more like a quick solution for user requests such as #663.
This is built on top of #701, by adding a global option to always prompt for OTP and submit it concatenated with password. Submitting as a separate PR as I'm not fully convinced of the need for this.
The newly extended static-challenge config option (GUI support is in PR #701) that can optionally specify concatenation format should be preferred over this. Always prompting for OTP could confuse users when none are required. But the former will be available only in OpenVPN 2.7 while this is immediately usable.