Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for swift-docc documentation and bump to Swift 5.7 #2

Merged
merged 15 commits into from
Dec 19, 2023

Conversation

Kyle-Ye
Copy link
Member

@Kyle-Ye Kyle-Ye commented Nov 20, 2023

Add initial support for swift-docc documentation.

Use SwiftPackageIndex here for simplifness. We can also host it on OpenCombine's GitHub Page if we have concern about it.

Also bump the minimal supported version to Swift 5.7 since Swift 5.9 is already released.
(Dropping Swift 5.7- support will make the adoption easier for the upcoming Swift 6.)

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (1c6f02c) 97.74% compared to head (2a8bde7) 97.89%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main       #2      +/-   ##
==========================================
+ Coverage   97.74%   97.89%   +0.14%     
==========================================
  Files         106      105       -1     
  Lines        7633     7689      +56     
==========================================
+ Hits         7461     7527      +66     
+ Misses        172      162      -10     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Kyle-Ye Kyle-Ye changed the title [DNM] Test workflow for docc Update GitHub CI Dec 18, 2023
@Kyle-Ye Kyle-Ye changed the base branch from master to main December 18, 2023 16:21
@Kyle-Ye Kyle-Ye force-pushed the optimize/docc branch 2 times, most recently from 0a67d10 to 781a5f5 Compare December 18, 2023 16:27
@Kyle-Ye Kyle-Ye force-pushed the optimize/docc branch 2 times, most recently from 9497cfd to 2720542 Compare December 18, 2023 17:52
@Kyle-Ye Kyle-Ye changed the title Update GitHub CI Initial support for swift-docc documentation and bump to Swift 5.7 Dec 18, 2023
@Kyle-Ye Kyle-Ye force-pushed the optimize/docc branch 2 times, most recently from 916233a to 26661ef Compare December 18, 2023 19:02
@Kyle-Ye Kyle-Ye force-pushed the optimize/docc branch 2 times, most recently from 881b858 to 2f72995 Compare December 19, 2023 04:01
@Kyle-Ye Kyle-Ye merged commit 3b505ba into main Dec 19, 2023
9 checks passed
@Kyle-Ye Kyle-Ye deleted the optimize/docc branch December 28, 2023 13:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants