Improve YAML parsing to handle list sequences within SLI spec #325
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will allow more YAML configurations within the SLI spec as lists were previously not parsed.
Within my org we're wanting to allow our users to see SLOs by cluster, or server. This is likely niche, but we're doing this by allowing users to define the Prometheus labels to scrape. e.g.
sum(http_requests_total{}) by (cluster)
. To do this we're wanting the spec to look like the following.This may be niche, but we believe that the spec was written to be open minded regarding the format within the
metricSource.spec
, so this should be supported.FYI, the output of this within the Go struct matches the existing format with
dimensions
beingcluster;server