Skip to content

Commit

Permalink
Issue 1531: fixes undefined hub in spike prime / robot inventor gener…
Browse files Browse the repository at this point in the history
…ated code
  • Loading branch information
PamoCurtis committed Aug 7, 2023
1 parent 73fbf1c commit 6320dd3
Show file tree
Hide file tree
Showing 10 changed files with 8 additions and 19 deletions.
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Sensors:
[]
Actors:
[UsedActor [, DISPLAY], UsedActor [, HUB]]
[UsedActor [, DISPLAY]]
Methods:
[]
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Sensors:
[]
Actors:
[UsedActor [, HUB]]
[]
Methods:
[GETMIDI, SETSTATUSLIGHT]
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Sensors:
[UsedSensor [B, TOUCH, PRESSED]]
Actors:
[UsedActor [, HUB]]
[]
Methods:
[SETSTATUSLIGHT]
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Sensors:
[UsedSensor [1, TIMER, DEFAULT], UsedSensor [F, COLOR, DEFAULT], UsedSensor [U, ULTRASONIC, DISTANCE], UsedSensor [B, TOUCH, PRESSED], UsedSensor [B, TOUCH, FORCE], UsedSensor [1, TIMER, VALUE]]
Actors:
[UsedActor [, HUB]]
[]
Methods:
[GETSAMPLEULTRASONIC, SETSTATUSLIGHT]
Original file line number Diff line number Diff line change
Expand Up @@ -4,6 +4,7 @@
TRACKWIDTH = 11.5
diff_drive = spike.MotorPair('A', 'B')
diff_drive.set_motor_rotation(5.6 * math.pi, 'cm')
hub = spike.PrimeHub()

def run():
# drive
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@
from spike.control import wait_for_seconds, wait_until
motorB = spike.Motor('B')
motorA = spike.Motor('A')
hub = spike.PrimeHub()

def run():
# motor
Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import spike
import math
from spike.control import wait_for_seconds, wait_until

touch_sensor_B = spike.ForceSensor('F')
hub = spike.PrimeHub()

Expand Down
Original file line number Diff line number Diff line change
@@ -1,7 +1,6 @@
import spike
import math
from spike.control import wait_for_seconds, wait_until, Timer

touch_sensor_B = spike.ForceSensor('F')
touch_sensor_B = spike.ForceSensor('F')
ultrasonic_sensor_U = spike.DistanceSensor('D')
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -702,10 +702,8 @@ protected void generateProgramPrefix(boolean withWrapping) {
nlIndent();
this.src.add("timer = Timer()");
}
if ( usedHardwareBean.isActorUsed("HUB") ) {
nlIndent();
this.src.add("hub = spike.PrimeHub()");
}
nlIndent();
this.src.add("hub = spike.PrimeHub()");
generateNNStuff("python");
}

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,6 @@ public Void visitColorSensor(ColorSensor colorSensor) {

@Override
public Void visitDisplayClearAction(DisplayClearAction displayClearAction) {
usedHardwareBuilder.addUsedActor(new UsedActor("", "HUB"));
return null;
}

Expand All @@ -89,19 +88,16 @@ public Void visitDisplayTextAction(DisplayTextAction displayTextAction) {
requiredComponentVisited(displayTextAction, displayTextAction.textToDisplay);
checkActorPort(displayTextAction);
usedHardwareBuilder.addUsedActor(new UsedActor("", "DISPLAY"));
usedHardwareBuilder.addUsedActor(new UsedActor("", "HUB"));
return null;
}

@Override
public Void visitGestureSensor(GestureSensor gestureSensor) {
usedHardwareBuilder.addUsedActor(new UsedActor("", "HUB"));
return null;
}

@Override
public Void visitGyroSensor(GyroSensor gyroSensor) {
usedHardwareBuilder.addUsedActor(new UsedActor("", "HUB"));
return null;
}

Expand All @@ -113,21 +109,18 @@ public Void visitImage(Image image) {
@Override
public Void visitKeysSensor(KeysSensor keysSensor) {
checkSensorPort(keysSensor);
usedHardwareBuilder.addUsedActor(new UsedActor("", "HUB"));
return null;
}

@Override
public Void visitRgbLedOffHiddenAction(RgbLedOffHiddenAction rgbLedOffHiddenAction) {
usedHardwareBuilder.addUsedActor(new UsedActor("", "HUB"));
return null;
}

@Override
public Void visitRgbLedOnHiddenAction(RgbLedOnHiddenAction rgbLedOnHiddenAction) {
requiredComponentVisited(rgbLedOnHiddenAction, rgbLedOnHiddenAction.colour);
usedMethodBuilder.addUsedMethod(SpikeMethods.SETSTATUSLIGHT);
usedHardwareBuilder.addUsedActor(new UsedActor("", "HUB"));
return null;
}

Expand Down Expand Up @@ -211,15 +204,13 @@ public Void visitMotorStopAction(MotorStopAction motorStopAction) {
@Override
public Void visitPlayNoteAction(PlayNoteAction playNoteAction) {
checkActorPort(playNoteAction);
usedHardwareBuilder.addUsedActor(new UsedActor("", "HUB"));
return null;
}

@Override
public Void visitPlayToneAction(PlayToneAction playToneAction) {
requiredComponentVisited(playToneAction, playToneAction.frequency, playToneAction.duration);
checkActorPort(playToneAction);
usedHardwareBuilder.addUsedActor(new UsedActor("", "HUB"));
usedMethodBuilder.addUsedMethod(SpikeMethods.GETMIDI);
return null;
}
Expand Down

0 comments on commit 6320dd3

Please sign in to comment.