Issue #1547: fix NN not being updated after sim run.

OpenRoberta · Aug 25, 2023 · 5727612 · 5727612
1 parent 3cf94f7
commit 5727612
Show file tree

Hide file tree

Showing 2 changed files with 10 additions and 14 deletions.
diff --git a/OpenRobertaServer/staticResources/js/app/neuralnetwork/neuralnetwork.ui.js b/OpenRobertaServer/staticResources/js/app/neuralnetwork/neuralnetwork.ui.js
@@ -848,15 +848,13 @@ define(["require", "exports", "./neuralnetwork.helper", "./neuralnetwork.nn", ".
         if (rememberProgramWasReplaced) {
             return; // program was imported. Old NN should NOT be saved
         }
-        if (neuralNetwork) {
-            network = neuralNetwork;
-        }
+        var networkToSave = neuralNetwork ? neuralNetwork : network;
         var startBlock = UTIL.getTheStartBlock();
         try {
-            state.weights = network.getWeightArray();
-            state.biases = network.getBiasArray();
-            state.inputs = network.getInputNames();
-            state.outputs = network.getOutputNames();
+            state.weights = networkToSave.getWeightArray();
+            state.biases = networkToSave.getBiasArray();
+            state.inputs = networkToSave.getInputNames();
+            state.outputs = networkToSave.getOutputNames();
             startBlock.data = JSON.stringify(state);
         }
         catch (e) {

diff --git a/OpenRobertaWeb/src/app/neuralnetwork/neuralnetwork.ui.ts b/OpenRobertaWeb/src/app/neuralnetwork/neuralnetwork.ui.ts
@@ -875,15 +875,13 @@ export function saveNN2Blockly(neuralNetwork?: Network): void {
     if (rememberProgramWasReplaced) {
         return; // program was imported. Old NN should NOT be saved
     }
-    if (neuralNetwork) {
-        network = neuralNetwork;
-    }
+    let networkToSave: Network = neuralNetwork ? neuralNetwork : network;
     var startBlock = UTIL.getTheStartBlock();
     try {
-        state.weights = network.getWeightArray();
-        state.biases = network.getBiasArray();
-        state.inputs = network.getInputNames();
-        state.outputs = network.getOutputNames();
+        state.weights = networkToSave.getWeightArray();
+        state.biases = networkToSave.getBiasArray();
+        state.inputs = networkToSave.getInputNames();
+        state.outputs = networkToSave.getOutputNames();
         startBlock.data = JSON.stringify(state);
     } catch (e) {
         LOG.error('failed to create a JSON string from nn state');