Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Give mod own logo #97

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Give mod own logo #97

wants to merge 1 commit into from

Conversation

MustaphaTR
Copy link
Member

Closes #94.

I didn't use the existing logo at mod folder but replaced it too in PR. I took the image used in the loadscreen (bigplan.cps). Cut the planet out, make it properly circular and resize as necessary.

Also added Website and WebIcon32 defitions to mod.yaml.

@evgeniysergeev
Copy link
Collaborator

evgeniysergeev commented Jan 1, 2019

The logo here looks great. But it taken from assets from .PAK files that user should get himself (preferably bye). I don’t think it is good idea to get image from bigplan.cps. This is why parser for cps file made and this is why current logo.png made: to not to use this one from original .PAK files

@MustaphaTR
Copy link
Member Author

MustaphaTR commented Jan 1, 2019

You are overestimating possible copyright issues. This is heavily edited over the .cps file. Modlogo can't be gotten from the original files, and i don't think using a complately custom logo is a good idea for a mod that aims to be as close to original as possible.

@evgeniysergeev
Copy link
Collaborator

Highly possibly that I overestimate that. But I think better to create logo from scratch without using original assets. Current logo can be replaced of course, but really don’t want to use image from protected by copyright assets

@MustaphaTR
Copy link
Member Author

If you can make something that is 128x128 at least but preferably 256x256, i can resize them and apply them to .ico/.icns files and update this PR.

@Mailaender
Copy link
Member

You could use something stylized like

Dune Legacy logo

Also comes with https://github.com/katlogic/dunelegacy/blob/master/dunelegacy.svg a scalable version.

@evgeniysergeev
Copy link
Collaborator

evgeniysergeev commented Apr 28, 2020

You could use something stylized like

Dune Legacy logo

Also comes with https://github.com/katlogic/dunelegacy/blob/master/dunelegacy.svg a scalable version.

This look reasonable, but may be better to make own icon. I already set maximum priority to this issue. Will make something

@penev92
Copy link
Member

penev92 commented Nov 14, 2021

@evgeniysergeev has there been progress on this? Will you make a logo? Shall we make a logo? Can we use one of the suggested?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Blocker Have issues that blocked by this one Enhancement Important
Projects
None yet
Development

Successfully merging this pull request may close these issues.

packaging/linux contains icons belonging to the SDK, ones belonging to this mod would be preferable
4 participants