Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update pt-BR translation #613

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Update pt-BR translation #613

merged 1 commit into from
Jul 12, 2023

Conversation

guilhermgonzaga
Copy link
Contributor

Hello.

I'm willing to update the portuguese translations for cups, but it's a lot of work, just over 2500 msgs left.
I would like to know if you impose a line length limit, or there is some build step before submitting the PR.
I'm using checkpo.

@zdohnal
Copy link
Member

zdohnal commented May 31, 2023

Hi @guilhermgonzaga ,

thank you for the PR! IMHO we don't impose a line length limit regarding code style in .po files, however there are string length limits in the library - max length for formatted strings (const message + variable values) is 2046, and for non-formatted string it is 8188.

AFAIK there is no additional build step if I understand Makefile correctly - we generate cups.strings from cups_en.po, so localized .pos don't seem to be used during build.

@michaelrsweet please let me know if it is correct - I've checked this by looking into the code.

@zdohnal zdohnal added this to the v2.4.x milestone May 31, 2023
@michaelrsweet
Copy link
Member

@zdohnal Correct, you just put the new .po file in the locale directory and the configure/install steps will use it automatically.

@guilhermgonzaga
Copy link
Contributor Author

Ok, thanks for the tip.

I added more translations in the meantime, but that's all I can translate for now. PR is ready.

@guilhermgonzaga guilhermgonzaga marked this pull request as ready for review July 4, 2023 02:40
Copy link
Member

@zdohnal zdohnal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@zdohnal zdohnal merged commit 30626be into OpenPrinting:master Jul 12, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants