-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Install all dependencies #68
base: main
Are you sure you want to change the base?
Conversation
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. PR Reviewer Guide 🔍
|
PR-Agent was enabled for this repository. To continue using it, please link your git user with your CodiumAI identity here. PR Code Suggestions ✨
|
The workflow is currently failing since |
I updated the delete artifact version (see #71) |
The PR (OpenMS/OpenMS#7529) in the main repository is now merged. We decided on different flags which I just updated for this PR as well. |
User description
This PR adds portable versions of all dependencies to the windows installations using the
cpack
routine from the installer.Note that this required some changes to the OpenMS build configuration and is thus dependent on the following PR in the main repository:
OpenMS/OpenMS#7529
This should fix #67.
PR Type
enhancement, configuration changes
Description
ctest
andcpack
to both GitHub Actions workflows.Changes walkthrough 📝
build-windows-executable-app-with-pyinstaller.yaml
Add packaging step and consolidate artifact handling
.github/workflows/build-windows-executable-app-with-pyinstaller.yaml
ctest
andcpack
.a single package upload.
package format.
replaced with package artifact deletion.
build-windows-executable-app.yaml
Add packaging step and consolidate artifact handling
.github/workflows/build-windows-executable-app.yaml
ctest
andcpack
.a single package upload.
package format.
replaced with package artifact deletion.